maybe we just needed enclos=?

MichaelChirico · web-flow · commit 7a87706ec0ea · 2025-01-16T15:12:24.000-08:00
diff --git a/R/data.table.R b/R/data.table.R
@@ -2989,9 +2989,9 @@ setDT = function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE) {
     }
   } else if (name %iscall% "get") { # #6725
     name = match.call(get, name)
-    e = eval(name$envir, parent.frame(), parent.frame())
-    k = eval(name$x, parent.frame(), parent.frame())
-    assign(k, x, envir=e)
+    name[[1L]] = quote(assign)
+    name$value = x
+    eval(name, parent.frame(), parent.frame())
   }
   .Call(CexpandAltRep, x)  # issue#2866 and PR#2882
   invisible(x)

Original file line number	Diff line number	Diff line change
`@@ -2989,9 +2989,9 @@ setDT = function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE) {`
`2989`	`2989`	`}`
`2990`	`2990`	`} else if (name %iscall% "get") { # #6725`
`2991`	`2991`	`name = match.call(get, name)`
`2992`		`- e = eval(name$envir, parent.frame(), parent.frame())`
`2993`		`- k = eval(name$x, parent.frame(), parent.frame())`
`2994`		`- assign(k, x, envir=e)`
	`2992`	`+ name[[1L]] = quote(assign)`
	`2993`	`+ name$value = x`
	`2994`	`+ eval(name, parent.frame(), parent.frame())`
`2995`	`2995`	`}`
`2996`	`2996`	`.Call(CexpandAltRep, x) # issue#2866 and PR#2882`
`2997`	`2997`	`invisible(x)`