Skip to content

Commit 7f43da5

Browse files
committed
changed id
1 parent 5169495 commit 7f43da5

File tree

1 file changed

+13
-14
lines changed

1 file changed

+13
-14
lines changed

.ci/atime/tests.R

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -286,23 +286,22 @@ test.list <- atime::atime_test_list(
286286
Slow = "548410d23dd74b625e8ea9aeb1a5d2e9dddd2927", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/548410d23dd74b625e8ea9aeb1a5d2e9dddd2927)
287287
Fast = "c0b32a60466bed0e63420ec105bc75c34590865e"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7144/commits) that uses a much faster implementation
288288

289-
"tables() !recursive refactor in #2606" = atime::atime_test(
289+
"tables() non-recursive performance in #2606" = atime::atime_test(
290+
N = as.integer(10^seq(1, 4, by = 0.5)),
290291
setup = {
291-
test_env <- new.env()
292-
local({
293-
for (i in 1:N) {
294-
assign(paste0("dt_perf_test", i), data.table(a=1), envir = test_env)
295-
assign(paste0("vec_perf_test", i), 1, envir = test_env)
296-
}
297-
})
298-
test_env
292+
for (i in 1:N) {
293+
assign(paste0("DT_perf_test_", i), data.table(a = 1))
294+
}
299295
},
300296
expr = {
301-
data.table::tables(env = test_env, silent = TRUE, index = TRUE);
302-
NULL
297+
if ("recursive" %in% names(formals(data.table::tables))) {
298+
data.table::tables(silent = TRUE, recursive = FALSE)
299+
} else {
300+
data.table::tables(silent = TRUE)
301+
}
303302
},
304-
before = "2b191aec3df51675a7ab5e6701384a8b89470af6", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/2b191aec3df51675a7ab5e6701384a8b89470af6)
305-
after = "66024e6ea5304ae059b1e96d3eda7e542471720a"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7141/commits) that uses a much faster implementation
306-
303+
before = "7c59daaed1836db57747d92494b1ce96612bbf80", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/7c59daaed1836db57747d92494b1ce96612bbf80)
304+
after = "6fee38c89200e10dcc10a6f2057ab784f9a011e7"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7141/commits)
305+
307306
tests=extra.test.list)
308307
# nolint end: undesirable_operator_linter.

0 commit comments

Comments
 (0)