Use *linter naming & organization for md linters (#7143)

Author: MichaelChirico

.ci/linters/md/news_linter.R …rs/md/news_github_link_mismatch_linter.R.ci/linters/md/news_linter.R renamed to .ci/linters/md/news_github_link_mismatch_linter.R .ci/linters/md/news_linter.R renamed to .ci/linters/md/news_github_link_mismatch_linter.R

@@ -1,32 +1,6 @@
-# ensure that numbered list in each section is in sequence
-check_section_numbering = function(news) {
-  if (!grepl("NEWS", news)) return(invisible())
-  news = readLines(news)
-  # plain '#' catches some examples; 'd' for 'data.table'
-  sections = grep("^#+ [A-Zd]", news)
-  entries = grep("^[0-9]+[.]", news)
-  entry_value = as.integer(gsub("^([0-9]+)[.].*", "\\1", news[entries]))
-  section_id = findInterval(entries, sections)
-
-  any_mismatch = FALSE
-  for (id in unique(section_id)) {
-    section_entries = entry_value[section_id == id]
-    intended_value = seq_along(section_entries)
-    matched = section_entries == intended_value
-    if (all(matched)) next
-    any_mismatch = TRUE
-    section_header = news[sections[id]]
-    cat(sprintf(
-      "In section '%s' (line %d), bad numbering:\n%s\n",
-      section_header, sections[id],
-      paste0("  [", section_entries[!matched], " --> ", intended_value[!matched], "]", collapse="\n")
-    ))
-  }
-  stopifnot("Please fix the NEWS issues above" = !any_mismatch)
-}
-
 # ensure that GitHub link text & URL actually agree
-check_gh_links = function(news) {
+news_github_link_mismatch_linter = function(news) {
+  if (!grepl("NEWS", news)) return(invisible())
   news = readLines(news)
   gh_links_info = gregexpr(
     "\\[#(?<md_number>[0-9]+)\\]\\(https://github.com/Rdatatable/data.table/(?<link_type>[^/]+)/(?<link_number>[0-9]+)\\)",

.ci/linters/md/news_section_numbering_linter.R

@@ -0,0 +1,26 @@
+# ensure that numbered list in each section is in sequence
+news_section_numbering_linter = function(news) {
+  if (!grepl("NEWS", news)) return(invisible())
+  news = readLines(news)
+  # plain '#' catches some examples; 'd' for 'data.table'
+  sections = grep("^#+ [A-Zd]", news)
+  entries = grep("^[0-9]+[.]", news)
+  entry_value = as.integer(gsub("^([0-9]+)[.].*", "\\1", news[entries]))
+  section_id = findInterval(entries, sections)
+
+  any_mismatch = FALSE
+  for (id in unique(section_id)) {
+    section_entries = entry_value[section_id == id]
+    intended_value = seq_along(section_entries)
+    matched = section_entries == intended_value
+    if (all(matched)) next
+    any_mismatch = TRUE
+    section_header = news[sections[id]]
+    cat(sprintf(
+      "In section '%s' (line %d), bad numbering:\n%s\n",
+      section_header, sections[id],
+      paste0("  [", section_entries[!matched], " --> ", intended_value[!matched], "]", collapse="\n")
+    ))
+  }
+  stopifnot("Please fix the NEWS issues above" = !any_mismatch)
+}

.ci/linters/md/heading_id_linter.R …/linters/md/vignette_heading_id_linter.R.ci/linters/md/heading_id_linter.R renamed to .ci/linters/md/vignette_heading_id_linter.R .ci/linters/md/heading_id_linter.R renamed to .ci/linters/md/vignette_heading_id_linter.R

@@ -1,6 +1,6 @@
 # ensure that ids are limited to alphanumerics and dashes
 # (in particular, dots and underscores break the links)
-check_header_ids = function(md) {
+vignette_heading_id_linter = function(md) {
   if (!grepl('[.]Rmd$', md)) return(invisible())
   md = readLines(md)
   # A bit surprisingly, some headings don't start with a letter.