implemented improvements as requested

Author: badasahog

src/inrange.c

@@ -5,7 +5,7 @@ SEXP inrange(SEXP ansArg, SEXP xoArg, SEXP startsArg, SEXP lenArg)
 {
   int *ans = INTEGER(ansArg);
   const int *xo = INTEGER_RO(xoArg);
-  const int *starts = INTEGER(startsArg), *len = INTEGER_RO(lenArg);
+  const int *starts = INTEGER_RO(startsArg), *len = INTEGER_RO(lenArg);
   const int n = length(startsArg), nxo = length(xoArg);
   for (int i = 0; i < n; i++) {
     for (int j = starts[i] - 1; j < starts[i] - 1 + len[i]; j++) {

src/subset.c

@@ -49,17 +49,17 @@ void subsetVectorRaw(SEXP ans, SEXP source, SEXP idx, const bool anyNA)
 
   switch(TYPEOF(source)) {
   case INTSXP: case LGLSXP: {
-    int *sp = INTEGER(source);
+    const int *sp = INTEGER_RO(source);
     int *ap = INTEGER(ans);
     PARLOOP(NA_INTEGER)
   } break;
   case REALSXP : {
     if (INHERITS(source, char_integer64)) {
-      int64_t *sp = (int64_t *)REAL(source);
+      const int64_t *sp = (int64_t *)REAL_RO(source);
       int64_t *ap = (int64_t *)REAL(ans);
       PARLOOP(INT64_MIN)
     } else {
-      double *sp = REAL(source);
+      const double *sp = REAL_RO(source);
       double *ap = REAL(ans);
       PARLOOP(NA_REAL)
     }

src/transpose.c

@@ -11,16 +11,16 @@ SEXP transpose(SEXP l, SEXP fill, SEXP ignoreArg, SEXP keepNamesArg, SEXP listCo
     return(copyAsPlain(l));
   if (!isLogical(ignoreArg) || LOGICAL(ignoreArg)[0] == NA_LOGICAL)
     error(_("ignore.empty should be logical TRUE/FALSE."));
-  bool ignore = LOGICAL_RO(ignoreArg)[0];
+  const bool ignore = LOGICAL_RO(ignoreArg)[0];
   if (!(isNull(keepNamesArg) || (isString(keepNamesArg) && LENGTH(keepNamesArg) == 1)))
     error(_("keep.names should be either NULL, or the name of the first column of the result in which to place the names of the input"));
-  bool rn = !isNull(keepNamesArg);
+  const bool rn = !isNull(keepNamesArg);
   if (length(fill) != 1)
     error(_("fill must be a length 1 vector, such as the default NA"));
-  R_len_t ln = LENGTH(l);
+  const R_len_t ln = LENGTH(l);
   if (!IS_TRUE_OR_FALSE(listColsArg))
     error(_("list.cols should be logical TRUE/FALSE."));
-  bool listCol = LOGICAL_RO(listColsArg)[0];
+  const bool listCol = LOGICAL_RO(listColsArg)[0];
 
   // preprocessing
   int maxlen = 0, zerolen = 0;
@@ -39,7 +39,7 @@ SEXP transpose(SEXP l, SEXP fill, SEXP ignoreArg, SEXP keepNamesArg, SEXP listCo
   if (listCol) maxtype = VECSXP; // need to keep preprocessing for zerolen
   fill = PROTECT(coerceVector(fill, maxtype)); nprotect++;
   SEXP ans = PROTECT(allocVector(VECSXP, maxlen + rn)); nprotect++;
-  int anslen = (ignore) ? (ln - zerolen) : ln;
+  const int anslen = (ignore) ? (ln - zerolen) : ln;
   if (rn) {
     SEXP tt;
     SET_VECTOR_ELT(ans, 0, tt = allocVector(STRSXP, anslen));