Jan's clarifying comment

MichaelChirico · web-flow · commit 8b74cc6e6757 · 2025-07-02T09:59:28.000-07:00
diff --git a/R/data.table.R b/R/data.table.R
@@ -520,7 +520,7 @@ replace_dot_alias = function(e) {
       }
       i = .shallow(i, retain.key = TRUE)
       ans = bmerge(i, x, leftcols, rightcols, roll, rollends, nomatch, mult, ops, verbose=verbose)
-      if (mult == "error") mult = "all"
+      if (mult == "error") mult = "all" ## error should have been raised inside bmerge() call above already, if it wasn't continue as mult="all"
       xo = ans$xo ## to make it available for further use.
       # temp fix for issue spotted by Jan, test #1653.1. TODO: avoid this
       # 'setorder', as there's another 'setorder' in generating 'irows' below...

Original file line number	Diff line number	Diff line change
`@@ -520,7 +520,7 @@ replace_dot_alias = function(e) {`
`520`	`520`	`}`
`521`	`521`	`i = .shallow(i, retain.key = TRUE)`
`522`	`522`	`ans = bmerge(i, x, leftcols, rightcols, roll, rollends, nomatch, mult, ops, verbose=verbose)`
`523`		`- if (mult == "error") mult = "all"`
	`523`	`+ if (mult == "error") mult = "all" ## error should have been raised inside bmerge() call above already, if it wasn't continue as mult="all"`
`524`	`524`	`xo = ans$xo ## to make it available for further use.`
`525`	`525`	`# temp fix for issue spotted by Jan, test #1653.1. TODO: avoid this`
`526`	`526`	`# 'setorder', as there's another 'setorder' in generating 'irows' below...`