Skip to content

Commit 8cc2dd1

Browse files
authored
Fixed inconsistencies in .ci/atime/tests.R (#6492)
1 parent 365d2a3 commit 8cc2dd1

File tree

1 file changed

+9
-13
lines changed

1 file changed

+9
-13
lines changed

.ci/atime/tests.R

Lines changed: 9 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ test.list <- atime::atime_test_list(
7878
# Performance regression discussed in: https://github.com/Rdatatable/data.table/issues/4311
7979
# Fixed in: https://github.com/Rdatatable/data.table/pull/4440
8080
"shallow regression fixed in #4440" = atime::atime_test(
81-
N = 10^seq(3,8),
81+
N = 10^seq(3, 8),
8282
setup = {
8383
set.seed(1L)
8484
dt <- data.table(a = sample.int(N))
@@ -104,9 +104,9 @@ test.list <- atime::atime_test_list(
104104
dt_mod <- copy(dt)
105105
},
106106
expr = data.table:::`[.data.table`(dt_mod, , N := .N, by = g),
107-
Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits)
108-
Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR that introduced the issue (https://github.com/Rdatatable/data.table/pull/4491/commits)
109-
Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR that fixed the regression (https://github.com/Rdatatable/data.table/pull/5463/commits)
107+
Before = "be2f72e6f5c90622fe72e1c315ca05769a9dc854", # Parent of the regression causing commit (https://github.com/Rdatatable/data.table/commit/e793f53466d99f86e70fc2611b708ae8c601a451) in the PR (https://github.com/Rdatatable/data.table/pull/4491/commits) that introduced the issue
108+
Regression = "e793f53466d99f86e70fc2611b708ae8c601a451", # Commit responsible for regression in the PR (https://github.com/Rdatatable/data.table/pull/4491/commits) that introduced the issue
109+
Fixed = "58409197426ced4714af842650b0cc3b9e2cb842"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5463/commits) that fixed the regression
110110

111111
# Issue reported in: https://github.com/Rdatatable/data.table/issues/5426
112112
# To be fixed in: https://github.com/Rdatatable/data.table/pull/5427
@@ -120,23 +120,21 @@ test.list <- atime::atime_test_list(
120120
data.table:::setattr(L, "class", NULL)
121121
data.table:::setDT(L)
122122
},
123-
Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801)
124-
Fast = "1872f473b20fdcddc5c1b35d79fe9229cd9a1d15"), # Last commit in the PR that fixes the issue (https://github.com/Rdatatable/data.table/pull/5427/commits)
123+
Slow = "c4a2085e35689a108d67dacb2f8261e4964d7e12", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/7cc4da4c1c8e568f655ab5167922dcdb75953801) in the PR (https://github.com/Rdatatable/data.table/pull/5427/commits) that fixes the issue
124+
Fast = "af48a805e7a5026a0c2d0a7fd9b587fea5cfa3c4"), # Last commit in the PR (https://github.com/Rdatatable/data.table/pull/5427/commits) that fixes the issue
125125

126126
# Issue reported in: https://github.com/Rdatatable/data.table/issues/4200
127127
# To be fixed in: https://github.com/Rdatatable/data.table/pull/4558
128128
"DT[by] fixed in #4558" = atime::atime_test(
129129
N = 10^seq(1, 20),
130130
setup = {
131131
d <- data.table(
132-
id3 = sample(c(seq.int(N*0.9), sample( N*0.9, N*0.1, TRUE))),
132+
id = sample(c(seq.int(N * 0.9), sample(N * 0.9, N * 0.1, TRUE))),
133133
v1 = sample(5L, N, TRUE),
134134
v2 = sample(5L, N, TRUE)
135135
)
136136
},
137-
expr = {
138-
expr=data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id3)
139-
},
137+
expr = data.table:::`[.data.table`(d, , max(v1) - min(v2), by = id),
140138
Before = "7a9eaf62ede487625200981018d8692be8c6f134", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/515de90a6068911a148e54343a3503043b8bb87c) in the PR (https://github.com/Rdatatable/data.table/pull/4164/commits) that introduced the regression
141139
Regression = "c152ced0e5799acee1589910c69c1a2c6586b95d", # Parent of the first commit (https://github.com/Rdatatable/data.table/commit/15f0598b9828d3af2eb8ddc9b38e0356f42afe4f) in the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
142140
Fixed = "f750448a2efcd258b3aba57136ee6a95ce56b302"), # Second commit of the PR (https://github.com/Rdatatable/data.table/pull/4558/commits) that fixes the regression
@@ -151,9 +149,7 @@ test.list <- atime::atime_test_list(
151149
setkey(L, V1)
152150
},
153151
## New DT can safely retain key.
154-
expr = {
155-
data.table:::`[.data.table`(L, , .SD)
156-
},
152+
expr = data.table:::`[.data.table`(L, , .SD),
157153
Fast = "353dc7a6b66563b61e44b2fa0d7b73a0f97ca461", # Close-to-last merge commit in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
158154
Slow = "3ca83738d70d5597d9e168077f3768e32569c790", # Circa 2024 master parent of close-to-last merge commit (https://github.com/Rdatatable/data.table/commit/353dc7a6b66563b61e44b2fa0d7b73a0f97ca461) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue
159155
Slower = "cacdc92df71b777369a217b6c902c687cf35a70d"), # Circa 2020 parent of the first commit (https://github.com/Rdatatable/data.table/commit/74636333d7da965a11dad04c322c752a409db098) in the PR (https://github.com/Rdatatable/data.table/pull/4501/commits) that fixes the issue

0 commit comments

Comments
 (0)