Merge branch 'frolladapt2025' into frollapply-nneg

Author: jangorecki

NEWS.md

@@ -225,36 +225,36 @@
 
 18. New `frolladapt` helper function has been added to aid in preparation of adaptive length of rolling window width when dealing with _irregularly spaced ordered data_. This lets the user to apply a rolling function over a period without having to deal with gaps in a data where some periods might be missing, [#3241](https://github.com/Rdatatable/data.table/issues/3241). Thanks to @jangorecki for implementation.
 ```r
-idx = as.Date("2022-10-23") + c(0,1,4,5,6,7,9,10,14)
+idx = as.Date("2025-09-08") + c(0,1,4,5,6,7,9,10,14)
 dt = data.table(index=idx, value=seq_along(idx))
 dt
 #        index value
 #       <Date> <int>
-#1: 2022-10-23     1
-#2: 2022-10-24     2
-#3: 2022-10-27     3
-#4: 2022-10-28     4
-#5: 2022-10-29     5
-#6: 2022-10-30     6
-#7: 2022-11-01     7
-#8: 2022-11-02     8
-#9: 2022-11-06     9
+#1: 2025-09-08     1
+#2: 2025-09-09     2
+#3: 2025-09-12     3
+#4: 2025-09-13     4
+#5: 2025-09-14     5
+#6: 2025-09-15     6
+#7: 2025-09-17     7
+#8: 2025-09-18     8
+#9: 2025-09-22     9
 dt[, c("rollmean3","rollmean3days") := list(
   frollmean(value, 3),
   frollmean(value, frolladapt(index, 3), adaptive=TRUE)
   )]
 dt
 #        index value rollmean3 rollmean3days
 #       <Date> <int>     <num>         <num>
-#1: 2022-10-23     1        NA            NA
-#2: 2022-10-24     2        NA            NA
-#3: 2022-10-27     3         2           3.0
-#4: 2022-10-28     4         3           3.5
-#5: 2022-10-29     5         4           4.0
-#6: 2022-10-30     6         5           5.0
-#7: 2022-11-01     7         6           6.5
-#8: 2022-11-02     8         7           7.5
-#9: 2022-11-06     9         8           9.0
+#1: 2025-09-08     1        NA            NA
+#2: 2025-09-09     2        NA            NA
+#3: 2025-09-12     3         2           3.0
+#4: 2025-09-13     4         3           3.5
+#5: 2025-09-14     5         4           4.0
+#6: 2025-09-15     6         5           5.0
+#7: 2025-09-17     7         6           6.5
+#8: 2025-09-18     8         7           7.5
+#9: 2025-09-22     9         8           9.0
 ```
 
 ### BUG FIXES

R/froll.R

@@ -135,9 +135,9 @@ frolladapt = function(x, n, align="right", partial=FALSE, give.names=FALSE) {
   if (!identical(align, "right"))
     stopf("'align' other than 'right' has not yet been implemented")
   if (!isTRUEorFALSE(partial))
-    stopf("'partial' must be TRUE or FALSE")
+    stopf("'%s' must be TRUE or FALSE", "partial")
   if (!isTRUEorFALSE(give.names))
-    stopf("'give.names' must be TRUE or FALSE")
+    stopf("'%s' must be TRUE or FALSE", "give.names")
 
   if (length(n) == 1L) {
     ans = .Call(Cfrolladapt, x, n, partial)

src/frollR.c

@@ -216,7 +216,7 @@ SEXP frolladapt(SEXP xobj, SEXP kobj, SEXP partial) {
   int n = INTEGER(kobj)[0];
   if (n < 1L)
     error(_("'n' must be positive integer values (>= 1)"));
-  int *x = INTEGER(xobj);
+  int *x = INTEGER_RO(xobj);
   int64_t len = XLENGTH(xobj); // can be 0
 
   if (len && x[0] == NA_INTEGER)
@@ -264,4 +264,4 @@ SEXP frolladapt(SEXP xobj, SEXP kobj, SEXP partial) {
   }
   UNPROTECT(1);
   return ans;
-}
+}