better writing style

Mukulyadav2004 · tdhock · web-flow · commit 926bb0e6e004 · 2025-08-15T22:19:53.000+05:30
Co-authored-by: Toby Dylan Hocking &lt;tdhock5@gmail.com&gt;
diff --git a/R/fwrite.R b/R/fwrite.R
@@ -43,10 +43,10 @@ fwrite = function(x, file="", append=FALSE, quote="auto",
   }
   # Handle select argument using .shallow()
   if (!is.null(select)) {
-    if (is.integer(select) || is.numeric(select)) {  # numeric/integer avoids O(#cols) name-match overhead
-        cols = as.integer(select)
+    cols = if (is.integer(select) || is.numeric(select)) {  # numeric/integer avoids O(#cols) name-match overhead
+        as.integer(select)
     } else {
-        cols = colnamesInt(x, select)
+        colnamesInt(x, select)
     }
     if (is.data.table(x)) {
         if (length(cols) < NCOL(x) || !identical(cols, seq_len(NCOL(x)))) { # only build a shallow view when columns are reduced or reordered

Original file line number	Diff line number	Diff line change
`@@ -43,10 +43,10 @@ fwrite = function(x, file="", append=FALSE, quote="auto",`
`43`	`43`	`}`
`44`	`44`	`# Handle select argument using .shallow()`
`45`	`45`	`if (!is.null(select)) {`
`46`		`- if (is.integer(select) \|\| is.numeric(select)) { # numeric/integer avoids O(#cols) name-match overhead`
`47`		`- cols = as.integer(select)`
	`46`	`+ cols = if (is.integer(select) \|\| is.numeric(select)) { # numeric/integer avoids O(#cols) name-match overhead`
	`47`	`+ as.integer(select)`
`48`	`48`	`} else {`
`49`		`- cols = colnamesInt(x, select)`
	`49`	`+ colnamesInt(x, select)`
`50`	`50`	`}`
`51`	`51`	`if (is.data.table(x)) {`
`52`	`52`	`if (length(cols) < NCOL(x) \|\| !identical(cols, seq_len(NCOL(x)))) { # only build a shallow view when columns are reduced or reordered`