Skip to content

Commit 94a9b59

Browse files
closed parenthisis
1 parent 28705de commit 94a9b59

File tree

1 file changed

+35
-35
lines changed

1 file changed

+35
-35
lines changed

.ci/atime/tests.R

Lines changed: 35 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -286,42 +286,42 @@ test.list <- atime::atime_test_list(
286286
Slow = "548410d23dd74b625e8ea9aeb1a5d2e9dddd2927", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/548410d23dd74b625e8ea9aeb1a5d2e9dddd2927)
287287
Fast = "c0b32a60466bed0e63420ec105bc75c34590865e"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7144/commits) that uses a much faster implementation
288288

289-
# Test case adapted from https://github.com/Rdatatable/data.table/issues/4177 which is where the issue was reported.
290-
# Fixed in https://github.com/Rdatatable/data.table/pull/7236
291-
"fwrite select parameter improved in #4177 (N rows and 5 columns, select a,b,c)" = atime::atime_test(
292-
setup = {
293-
set.seed(1L)
294-
DT = data.table(a=rnorm(N), b=rnorm(N), c=rnorm(N), d=rnorm(N), e=rnorm(N))
295-
temp_file = tempfile()
296-
},
297-
expr = {
298-
has_select = "select" %chin% names(formals(data.table::fwrite))
299-
if (has_select) {
300-
data.table::fwrite(DT, temp_file, select = c("a","b","c"))
301-
} else {
302-
data.table::fwrite(DT[, c("a","b","c"), with = FALSE], temp_file)
303-
}
304-
},
305-
Slow = "66cb6d2393cef30083b444346a7600a079207806", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/66cb6d2393cef30083b444346a7600a079207806)
306-
Fast = "1887699fe965b5aa1fb8cb16b5507b7a5cbf5c85", # Commit in the PR (https://github.com/Rdatatable/data.table/pull/4177/commits) that adds select parameter
289+
# Test case adapted from https://github.com/Rdatatable/data.table/issues/4177 which is where the issue was reported.
290+
# Fixed in https://github.com/Rdatatable/data.table/pull/7236
291+
"fwrite select parameter improved in #4177 (N rows and 5 columns, select a,b,c)" = atime::atime_test(
292+
setup = {
293+
set.seed(1L)
294+
DT = data.table(a=rnorm(N), b=rnorm(N), c=rnorm(N), d=rnorm(N), e=rnorm(N))
295+
temp_file = tempfile()
296+
},
297+
expr = {
298+
has_select = "select" %chin% names(formals(data.table::fwrite))
299+
if (has_select) {
300+
data.table::fwrite(DT, temp_file, select = c("a","b","c"))
301+
} else {
302+
data.table::fwrite(DT[, c("a","b","c"), with = FALSE], temp_file)
303+
}
304+
},
305+
Slow = "66cb6d2393cef30083b444346a7600a079207806", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/66cb6d2393cef30083b444346a7600a079207806)
306+
Fast = "1887699fe965b5aa1fb8cb16b5507b7a5cbf5c85"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/4177/commits) that adds select parameter
307307

308-
# Wide case: 1 row, N columns; select a single column
309-
"fwrite select parameter improved in #4177 (N columns and 1 row, select 1)" = atime::atime_test(
310-
setup = {
311-
DT = data.table(t(1:N))
312-
temp_file = tempfile()
313-
select_idx = 1L
314-
},
315-
expr = {
316-
has_select = "select" %chin% names(formals(data.table::fwrite))
317-
if (has_select) {
318-
data.table::fwrite(DT, temp_file, select = select_idx)
319-
} else {
320-
data.table::fwrite(DT[, select_idx, with = FALSE], temp_file)
321-
}
322-
},
323-
Slow = "66cb6d2393cef30083b444346a7600a079207806", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/66cb6d2393cef30083b444346a7600a079207806)
324-
Fast = "1887699fe965b5aa1fb8cb16b5507b7a5cbf5c85", # Commit in the PR (https://github.com/Rdatatable/data.table/pull/4177/commits) that adds select parameter
308+
# Wide case: 1 row, N columns; select a single column
309+
"fwrite select parameter improved in #4177 (N columns and 1 row, select 1)" = atime::atime_test(
310+
setup = {
311+
DT = data.table(t(1:N))
312+
temp_file = tempfile()
313+
select_idx = 1L
314+
},
315+
expr = {
316+
has_select = "select" %chin% names(formals(data.table::fwrite))
317+
if (has_select) {
318+
data.table::fwrite(DT, temp_file, select = select_idx)
319+
} else {
320+
data.table::fwrite(DT[, select_idx, with = FALSE], temp_file)
321+
}
322+
},
323+
Slow = "66cb6d2393cef30083b444346a7600a079207806", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/66cb6d2393cef30083b444346a7600a079207806)
324+
Fast = "1887699fe965b5aa1fb8cb16b5507b7a5cbf5c85"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/4177/commits) that adds select parameter
325325

326326
tests=extra.test.list)
327327
# nolint end: undesirable_operator_linter.

0 commit comments

Comments
 (0)