Skip to content

Commit a5f40e8

Browse files
committed
Updated NEWS.md and tests.Rraw
1 parent e7d1412 commit a5f40e8

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

NEWS.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ rowwiseDT(
133133
134134
19. An integer overflow in `fread()` with lines longer than `2^(31/2)` bytes is prevented, [#6729](https://github.com/Rdatatable/data.table/issues/6729). The typical impact was no worse than a wrong initial allocation size, corrected later. Thanks to @TaikiSan21 for the report and @aitap for the fix.
135135
136-
20. By reference assignments (':=') with functions that modify the data.table by reference e.g. (`foo=function(DT){DT[,b:=1L];return(2L)}`, `DT[,a:=foo(DT)]`) returned a mallformed data.table due to the the modification of the targeted named column ("a") index before and after the j expression evaluation. Thanks @AntonNM for the the report and fix.
136+
20. By reference assignments (':=') with functions that modified the data.table by reference e.g. (`foo=function(DT){modify(DT);return(1L)}`, `DT[,a:=foo(DT)]`) returned a mallformed data.table due to the modification of the targeted named column index ("a") during the j expression evaluation. Thanks @AntonNM for the report and fix.
137137
138138
## NOTES
139139

inst/tests/tests.Rraw

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21068,5 +21068,7 @@ test(2305, { fread(testDir("issue_6729.txt.bz2")); TRUE })
2106821068
# j expressions that modify a data.table by reference, (#6768)
2106921069
inner=function(dt){dt[,b:=4:6]}
2107021070
outer=function(dt){inner(dt); return(7:9)}
21071+
foo=function(dt){dt[b:=4:6];return(7:9)}
2107121072
DT = data.table(a=1:3)
2107221073
test(2306, DT[,c:=outer(DT)], data.table(a=1:3, b=4:6, c=7:9))
21074+
test(2306.1, DT[,c:=foo(DT)], data.table(a=1:3, b=4:6, c=7:9))

0 commit comments

Comments
 (0)