Suppressed spurious min/max warnings in cube() internal structure-seeding eval() (#7110)

* suppressed warnings

* Clarify NEWS

* reference comment

* added tests

* Update tests.Rraw

* correct 2nd test, simplify

* fix (ugly)

* min->double type

---------

Co-authored-by: Michael Chirico <[email protected]>

Author: venom1204

NEWS.md

@@ -80,6 +80,8 @@
 
 18. Fixed incorrect sorting of merges where the first column of a key is a factor with non-`sort()`-ed levels (e.g. `factor(1:2, 2:1)` and it is joined to a character column, [#5361](https://github.com/Rdatatable/data.table/issues/5361). Thanks to @gbrunick for the report and Benjamin Schwendinger for the fix.
 
+19. Spurious warnings from internal code in `cube()`, `rollup()`, and `groupingsets()` are no longer surfaced to the caller, [#6964](https://github.com/Rdatatable/data.table/issues/6964). Thanks @ferenci-tamas for the report and @venom1204 for the fix.
+ 
 ### NOTES
 
 1. Continued work to remove non-API C functions, [#6180](https://github.com/Rdatatable/data.table/issues/6180). Thanks Ivan Krylov for the PRs and for writing a clear and concise guide about the R API: https://aitap.codeberg.page/R-api/.

R/groupingsets.R

@@ -115,7 +115,8 @@ groupingsets.data.table = function(x, j, by, sets, .SDcols, id = FALSE, jj, labe
   # inline all arguments that might clash with enclosing environment
   pcall = substitute(x[0L, jj, by], list(x = x, jj = jj, by = by))
   if (length(.SDcols)) pcall$.SDcols = .SDcols
-  empty = eval(pcall, list(.datatable.aware = TRUE), enclos)
+  # suppress e.g. the min(double()) warning, #6964
+  empty = suppressWarnings(eval(pcall, list(.datatable.aware = TRUE), enclos))
   if (id && "grouping" %chin% names(empty)) # `j` could have been evaluated to `grouping` field
     stopf("When using `id=TRUE` the 'j' expression must not evaluate to a column named 'grouping'.")
   if (anyDuplicated(names(empty)) > 0L)

inst/tests/tests.Rraw

@@ -21347,3 +21347,12 @@ local({
   test(2326.2, key(d), "x")
   test(2326.3, indices(d), c("y", "z"))
 })
+
+#6964
+# Test 1: No warning from min() with simple data
+DT = data.table(var = c("a", "b", "c", "d"), value=c(1:3, NA))
+test(2327.1, cube(DT, .(min(value)), "var"),
+     data.table(var = c("a", "b", "c", "d", NA), V1 = c(1.0, 2.0, 3.0, NA, NA)))
+test(2327.2, cube(DT, .(as.numeric(base::min(value, na.rm=TRUE))), "var"),
+     data.table(var = c("a", "b", "c", "d", NA), V1 = c(1.0, 2.0, 3.0, Inf, 1.0)),
+     warning="no non-missing arguments to min")