Merge branch 'master' of https://github.com/badasahog/data.table

Author: badasahog

src/fread.c

@@ -237,7 +237,7 @@ static inline void skip_white(const char **pch) {
   // skip space so long as sep isn't space and skip tab so long as sep isn't tab
   // always skip any \0 (NUL) that occur before end of file, #3400
   const char *ch = *pch;
-  if (whiteChar==0) {   // whiteChar==0 means skip both ' ' and '\t';  sep is neither ' ' nor '\t'.
+  if (whiteChar=='\0') {   // whiteChar==0 means skip both ' ' and '\t';  sep is neither ' ' nor '\t'.
     while (*ch==' ' || *ch=='\t' || (*ch=='\0' && ch<eof)) ch++;
   } else {
     while (*ch==whiteChar || (*ch=='\0' && ch<eof)) ch++;  // sep is ' ' or '\t' so just skip the other one.
@@ -1673,7 +1673,7 @@ int freadMain(freadMainArgs _args) {
     // unusual
     if (verbose) DTPRINT(_("  sep='\\n' passed in meaning read lines as single character column\n"));
     sep = 127;     // ASCII DEL: a character different from \r, \n and \0 that isn't in the data
-    whiteChar = 0;
+    whiteChar = '\0';
     quoteRule = 3; // Ignore quoting
     ncol = 1;
     int thisLine=0;

src/fsort.c

@@ -18,13 +18,13 @@ static void dinsert(double *x, const int n) {   // TODO: if and when twiddled, d
 
 static uint64_t minULL;
 
-static void dradix_r(  // single-threaded recursive worker
-  double *in,          // n doubles to be sorted
-  double *working,     // working memory to put the sorted items before copying over *in; must not overlap *in
-  uint64_t n,          // number of items to sort.  *in and *working must be at least n long
-  int fromBit,         // After twiddle to ordered ull, the bits [fromBit,toBit] are used to count
-  int toBit,           //   fromBit<toBit; bit 0 is the least significant; fromBit is right shift amount too
-  uint64_t *counts     // already zero'd counts vector, 2^(toBit-fromBit+1) long. A stack of these is reused.
+static void dradix_r(            // single-threaded recursive worker
+  double * restrict in,          // n doubles to be sorted
+  double * restrict working,     // working memory to put the sorted items before copying over *in; must not overlap *in
+  uint64_t n,                    // number of items to sort.  *in and *working must be at least n long
+  int fromBit,                   // After twiddle to ordered ull, the bits [fromBit,toBit] are used to count
+  int toBit,                     //   fromBit<toBit; bit 0 is the least significant; fromBit is right shift amount too
+  uint64_t * restrict counts     // already zero'd counts vector, 2^(toBit-fromBit+1) long. A stack of these is reused.
 ) {
   uint64_t width = 1ULL<<(toBit-fromBit+1);
   uint64_t mask = width-1;

src/fwriteR.c

@@ -75,16 +75,15 @@ static int32_t whichWriter(SEXP);
 
 void writeList(const void *col, int64_t row, char **pch) {
   SEXP v = ((const SEXP *)col)[row];
-  int32_t wf = whichWriter(v);
+  const int32_t wf = whichWriter(v);
   if (TYPEOF(v)==VECSXP || wf==INT32_MIN || isFactor(v)) {
     internal_error(__func__, "TYPEOF(v)!=VECSXP && wf!=INT32_MIN && !isFactor(v); getMaxListItem should have caught this up front");  // # nocov
   }
   char *ch = *pch;
   write_chars(sep2start, &ch);
   const void *data = DATAPTR_RO(v);
-  writer_fun_t *fun = funs[wf];
   for (int j=0; j<LENGTH(v); j++) {
-    (*fun)(data, j, &ch);
+    funs[wf](data, j, &ch);
     *ch++ = sep2;
   }
   if (LENGTH(v)) ch--; // backup over the last sep2 after the last item