Skip to content

Commit b5a41a0

Browse files
fixed bad merge? and drop sort()
1 parent 1df35b0 commit b5a41a0

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

R/bmerge.R

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@ bmerge = function(i, x, icols, xcols, roll, rollends, nomatch, mult, ops, verbos
9494
}
9595
# data.table::as.ITime, chron::times, nanotime::nanotime
9696
time_classes = c("Date", "POSIXt", "ITime", "times", "nanotime")
97-
x_class_time = intersect(class(x[[xc]]), time_classes)
98-
i_class_time = intersect(class(i[[ic]]), time_classes)
99-
if (length(x_class_time) > 0L && length(i_class_time) > 0L && !identical(sort(x_class_time), sort(i_class_time))) {
97+
x_class_time = intersect(class(x[[xcol]]), time_classes)
98+
i_class_time = intersect(class(i[[icol]]), time_classes)
99+
if (length(x_class_time) > 0L && length(i_class_time) > 0L && !identical(x_class_time, i_class_time)) {
100100
warningf("Attempting to join column %s (%s) with column %s (%s). They are likely to be incompatible, so we suggest you convert one to the other's class.",
101101
xname, toString(x_class_time), iname, toString(i_class_time))
102102
}

0 commit comments

Comments
 (0)