add changes

Author: Mukulyadav2004

R/data.table.R

@@ -1183,7 +1183,7 @@ replace_dot_alias = function(e) {
         } else {
           # Adding new column(s). TO DO: move after the first eval in case the jsub has an error.
           newnames=setdiff(lhs, names_x)
-          m[is.na(m)] = ncol(x)+seq_len(length(newnames))
+          m[is.na(m)] = ncol(x)+seq_along(newnames)
           cols = as.integer(m)
           # don't pass verbose to selfrefok here -- only activated when
           #   ok=-1 which will trigger setalloccol with verbose in the next
@@ -2380,7 +2380,7 @@ subset.data.table = function(x, subset, select, ...)
       ## Set the key on the returned data.table as long as the key
       ## columns that "remain" are the same as the original, or a
       ## prefix of it.
-      is.prefix = all(key(x)[seq_len(length(key.cols))] == key.cols)
+      is.prefix = all(key(x)[seq_along(key.cols)] == key.cols)
       if (is.prefix) {
         setattr(ans, "sorted", key.cols)
       }
@@ -2867,7 +2867,7 @@ setDF = function(x, rownames=NULL) {
       stopf("All elements in argument 'x' to 'setDF' must be of same length")
     xn = names(x)
     if (is.null(xn)) {
-      setattr(x, "names", paste0("V",seq_len(length(x))))
+      setattr(x, "names", paste0("V",seq_along(x)))
     } else {
       idx = !nzchar(xn) # NB: keepNA=FALSE intentional
       if (any(idx)) {

R/print.data.table.R

@@ -32,7 +32,7 @@ print.data.table = function(x, topn=getOption("datatable.print.topn"),
     SYS = sys.calls()
     if (identical(SYS[[1L]][[1L]], print) ||
         ( length(SYS) >= 3L && is.symbol(thisSYS <- SYS[[length(SYS)-2L]][[1L]]) &&
-          as.character(thisSYS) == 'source') ) { 
+          as.character(thisSYS) == 'source')) {
       return(invisible(x))
     }
   }
@@ -102,15 +102,15 @@ print.data.table = function(x, topn=getOption("datatable.print.topn"),
       expression = "<expr>", ordered = "<ord>")
     classes = classes1(x)
     col_names <- colnames(toprint)
-    index_cols <- paste0("index:", indices(x))  
+    index_cols <- paste0("index:", indices(x))
     for (col_name in col_names) {
       if (col_name %in% index_cols) {
         classes[col_name] <- "index"
       } else if (col_name %in% names(x)) {
         cls <- class(x[[col_name]])
-        if (is.list(cls)) cls <- unlist(cls)  
-        if (length(cls) == 0) cls <- "unknown"  
-        classes[col_name] <- cls[1]  
+        if (is.list(cls)) cls <- unlist(cls)
+        if (length(cls) == 0) cls <- "unknown"
+        classes[col_name] <- cls[1]
       } else {
         classes[col_name] <- "unknown"
       }

inst/tests/tests.Rraw

@@ -18784,11 +18784,6 @@ ans = c(
  "10:   83   64   41                 9                 9")
 # test where topn isn't necessary
 test(2264.8, print(DT, show.indices=TRUE), output=ans)
-# printing does not fail when indices are present
-test(2264.9, {
-  suppressWarnings( print(DT, show.indices=TRUE) )
-  TRUE 
-})
 
 # integer64 columns print even when bit64 isn't loaded
 if (test_bit64) local({
@@ -21046,3 +21041,20 @@ test(2304.100, set(copy(DT), i=2L, j=c("L1", "L2"), value=list(list(NULL), list(
 
 # the integer overflow in #6729 is only noticeable with UBSan
 test(2305, { fread(testDir("issue_6729.txt.bz2")); TRUE })
+
+# Tests for print.data.table handling index columns, list classes, and unknown classes in #6806
+
+# Test for covering classes[col_name] <- "index"
+DT = data.table(A = 1:3, B = 4:6)
+setindex(DT, A)
+test(108, DT, data.table(t(t(DT)), key = "A"))
+# Test for covering if (is.list(cls)) cls <- unlist(cls)
+DT = data.table(A = 1:3, B = list(NULL, NULL, NULL))
+test(109, DT, data.table(t(t(DT))))
+# Test for covering if (length(cls) == 0) cls <- "unknown"
+DT = data.table(A = 1:3, B = I(list()))
+test(110, DT, data.table(t(t(DT))))
+# Test for covering classes[col_name] <- "unknown"
+DT = data.table(A = 1:3, B = 4:6, C = 7:9)
+DT[, D := NULL]
+test(111, DT, data.table(t(t(DT))))