Merge pull request #6925 from ProfFancyPants/fread-fileinfo

MichaelChirico · web-flow · commit b70d0267ae89 · 2025-05-09T09:12:58.000-07:00
Updating fread's file.info argument to avoid uname and udomain lookup.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -100,5 +100,6 @@ Authors@R: c(
   person("Vincent", "Rocher",      role="ctb"),
   person("Vijay", "Lulla",         role="ctb"),
   person("Aljaž", "Sluga",         role="ctb"),
-  person("Bill", "Evans",          role="ctb")
+  person("Bill", "Evans",          role="ctb"),
+  person("Reino", "Bruner",        role="ctb")
   )
diff --git a/NEWS.md b/NEWS.md
@@ -28,6 +28,7 @@
 
 7. `fwrite()` now avoids a crash when translating strings into a different encoding, [#6883](https://github.com/Rdatatable/data.table/issues/6883). Thanks @filipemsc for the report and @aitap for the fix.
 
+8. `fread()` no longer warns on certain systems on R 4.5.0+ where the file owner can't be resolved, [#6918](https://github.com/Rdatatable/data.table/issues/6918). Thanks @ProfFancyPants for the report and PR.
 
 ## NOTES
 
diff --git a/R/fread.R b/R/fread.R
@@ -88,7 +88,7 @@ yaml=FALSE, tmpdir=tempdir(), tz="UTC")
       on.exit(unlink(tmpFile), add=TRUE)
       # nocov end
     }
-    file_info = file.info(file)
+    file_info = file.info(file, extra_cols=FALSE)
     if (is.na(file_info$size)) stopf("File '%s' does not exist or is non-readable. getwd()=='%s'", file, getwd())
     if (isTRUE(file_info$isdir)) stopf("File '%s' is a directory. Not yet implemented.", file) # Could use dir.exists(), but we already ran file.info().
     if (!file_info$size) {

Original file line number	Diff line number	Diff line change
`@@ -100,5 +100,6 @@ Authors@R: c(`
`100`	`100`	`person("Vincent", "Rocher", role="ctb"),`
`101`	`101`	`person("Vijay", "Lulla", role="ctb"),`
`102`	`102`	`person("Aljaž", "Sluga", role="ctb"),`
`103`		`- person("Bill", "Evans", role="ctb")`
	`103`	`+ person("Bill", "Evans", role="ctb"),`
	`104`	`+ person("Reino", "Bruner", role="ctb")`
`104`	`105`	`)`
Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@`
`28`	`28`
`29`	`29`	7. `fwrite()` now avoids a crash when translating strings into a different encoding, [#6883](https://github.com/Rdatatable/data.table/issues/6883). Thanks @filipemsc for the report and @aitap for the fix.
`30`	`30`
	`31`	+8. `fread()` no longer warns on certain systems on R 4.5.0+ where the file owner can't be resolved, [#6918](https://github.com/Rdatatable/data.table/issues/6918). Thanks @ProfFancyPants for the report and PR.
`31`	`32`
`32`	`33`	`## NOTES`
`33`	`34`
Original file line number	Diff line number	Diff line change
`@@ -88,7 +88,7 @@ yaml=FALSE, tmpdir=tempdir(), tz="UTC")`
`88`	`88`	`on.exit(unlink(tmpFile), add=TRUE)`
`89`	`89`	`# nocov end`
`90`	`90`	`}`
`91`		`- file_info = file.info(file)`
	`91`	`+ file_info = file.info(file, extra_cols=FALSE)`
`92`	`92`	`if (is.na(file_info$size)) stopf("File '%s' does not exist or is non-readable. getwd()=='%s'", file, getwd())`
`93`	`93`	`if (isTRUE(file_info$isdir)) stopf("File '%s' is a directory. Not yet implemented.", file) # Could use dir.exists(), but we already ran file.info().`
`94`	`94`	`if (!file_info$size) {`