update changes

Author: Mukulyadav2004

R/as.data.table.R

@@ -241,15 +241,15 @@ as.data.table.data.frame = function(x, keep.rownames=FALSE, key=NULL, ...) {
   # fix for #1078 and #1128, see .resetclass() for explanation.
   setattr(ans, "class", .resetclass(x, "data.frame"))
   setalloccol(ans)
-  if (!is.null(key)) setkeyv(ans, key)
+  setkeyv(ans, key)
   ans
 }
 
-as.data.table.data.table = function(x, ...) {
-  key = list(...)$key
+as.data.table.data.table = function(x, keep.rownames, key, ...) {
+  if (missing(key))  key = NULL
   # as.data.table always returns a copy, automatically takes care of #473
   if (any(cols_with_dims(x))) { # for test 2089.2
-    return(as.data.table.list(x, ...))
+    return(as.data.table.list(x, key = key, ...))
   }
   x = copy(x) # #1681
   # fix for #1078 and #1128, see .resetclass() for explanation.

inst/tests/tests.Rraw

@@ -21087,20 +21087,15 @@ test(2308.02, fread("date\nNA\n2014-12-05", keepLeadingZeros=FALSE), dt)
 
 # Test that as.data.table.data.table preserves key when explicitly specified but not when omitted
 # data.frame to data.table with key
-test(2309.01, {
-  key(as.data.table(data.frame(t = c(3:1, 4:5), y = 1:5), key="t"))
-}, "t")
+DF = data.frame(t = c(3:1, 4:5), y = 1:5)
+test(2309.01, key(as.data.table(DF, key="t")), "t")
 # tibble to data.table with key
 DF <- data.frame(t = c(3:1, 4:5), y = 1:5)
 class(DF) <- c("tbl_df", "tbl", "data.frame")
-test(2309.02, {
-  key(as.data.table(DF, key="t"))
-}, "t")
+test(2309.02, key(as.data.table(DF, key="t")), "t")
 # data.table to data.table with key
-test(2309.03, {
-  key(as.data.table(data.table(t = c(3:1, 4:5), y = 1:5), key="t"))
-}, "t")
+DT = data.table(t = c(3:1, 4:5), y = 1:5)
+test(2309.03, key(as.data.table(DT, key="t")), "t")
 # data.table to data.table without key
-test(2309.04, {
-  key(as.data.table(data.table(t = c(3:1, 4:5), key="t")))
-}, NULL)
+DT = data.table(t = c(3:1, 4:5), key="t")
+test(2309.04, key(as.data.table(DT)), NULL)

man/as.data.table.Rd

@@ -21,7 +21,7 @@ Functions to check if an object is \code{data.table}, or coerce it if possible.
 \usage{
 as.data.table(x, keep.rownames=FALSE, \dots)
 
-\method{as.data.table}{data.table}(x, \dots)
+\method{as.data.table}{data.table}(x, keep.rownames, key, \dots)
 
 \method{as.data.table}{array}(x, keep.rownames=FALSE, key=NULL, sorted=TRUE,
               value.name="value", na.rm=TRUE, \dots)