implement for bug

Author: MichaelChirico

R/cedta.R

@@ -28,8 +28,7 @@ cedta.pkgEvalsUserCode = c("gWidgetsWWW","statET","FastRWeb","slidify","rmarkdow
 
 # nocov start: very hard to reach this within our test suite -- the call stack within a call generated by e.g. knitr
 # for loop, not any(vapply_1b(.)), to allow early exit
-.any_eval_calls_in_stack = function() {
-  calls = sys.calls()
+.any_eval_calls_in_stack = function(calls) {
   # likelier to be close to the end of the call stack, right?
   for (ii in length(calls):1) { # nolint: seq_linter. rev(seq_len(length(calls)))? See https://bugs.r-project.org/show_bug.cgi?id=18406.
     the_call = calls[[ii]][[1L]]
@@ -39,6 +38,17 @@ cedta.pkgEvalsUserCode = c("gWidgetsWWW","statET","FastRWeb","slidify","rmarkdow
 }
 # nocov end
 
+.any_sd_queries_in_stack = function(calls) {
+  for (ii in length(calls):1) { # nolint: seq_linter. As above.
+    the_call = calls[[ii]][1L]
+    if (!is.name(the_call) || the_call != "[") next
+    the_lhs = calls[[ii]][[2L]]
+    if (!is.name(the_lhs) || the_lhs != ".SD") next
+    return(TRUE)
+  }
+  FALSE
+}
+
 # in a helper to promote readability
 # NB: put the most common and recommended cases first for speed
 .cedta_impl_ <- function(ns, n) {
@@ -47,17 +57,21 @@ cedta.pkgEvalsUserCode = c("gWidgetsWWW","statET","FastRWeb","slidify","rmarkdow
 
   if ("data.table" %chin% names(getNamespaceImports(ns))) return(TRUE)
 
+  sc <- sys.calls()
   if (nsname == "utils") {
     if (exists("debugger.look", parent.frame(n+1L))) return(TRUE)
 
     # 'example' for #2972
-    sc <- sys.calls()
     if (length(sc) >= 8L && sc[[length(sc) - 7L]] %iscall% 'example') return(TRUE)
   }
 
-  if (nsname == "base" && all(c("FUN", "X") %chin% ls(parent.frame(n)))) return(TRUE) # lapply
+  if (nsname == "base") {
+    if (all(c("FUN", "X") %chin% ls(parent.frame(n)))) return(TRUE) # lapply
+
+    if (.any_sd_queries_in_stack(sc)) return(TRUE) # e.g. lapply() where "piped-in" j= arg has .SD[]
+  }
 
-  if (nsname %chin% cedta.pkgEvalsUserCode && .any_eval_calls_in_stack()) return(TRUE)
+  if (nsname %chin% cedta.pkgEvalsUserCode && .any_eval_calls_in_stack(sc)) return(TRUE)
 
   if (nsname %chin% cedta.override) return(TRUE)