Skip to content

Commit c757efa

Browse files
committed
added atime test
1 parent dec9834 commit c757efa

File tree

3 files changed

+16
-3
lines changed

3 files changed

+16
-3
lines changed

.ci/atime/tests.R

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -286,5 +286,18 @@ test.list <- atime::atime_test_list(
286286
Slow = "548410d23dd74b625e8ea9aeb1a5d2e9dddd2927", # Parent of the first commit in the PR (https://github.com/Rdatatable/data.table/commit/548410d23dd74b625e8ea9aeb1a5d2e9dddd2927)
287287
Fast = "c0b32a60466bed0e63420ec105bc75c34590865e"), # Commit in the PR (https://github.com/Rdatatable/data.table/pull/7144/commits) that uses a much faster implementation
288288

289+
"tables() !recursive refactor in #2606" = atime::atime_test(
290+
N = as.integer(10^seq(1, 4, by=0.5)),
291+
setup = {
292+
rm(list=ls()[grepl("^(dt|vec)_perf_test", ls())])
293+
for (i in 1:N) {
294+
assign(paste0("dt_perf_test", i), data.table(a=1))
295+
assign(paste0("vec_perf_test", i), 1)
296+
}
297+
},
298+
expr = data.table::tables(silent=TRUE),
299+
"before" = "def1e47eea8822993a829e3fe8d36acc117d806b",
300+
"after" = "8978cf201d8d228506e1e96d3eda7e542471720a"),
301+
289302
tests=extra.test.list)
290303
# nolint end: undesirable_operator_linter.

R/tables.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ tables = function(mb=type_size, order.col="NAME", width=80L,
6262
} else {
6363
w = which(vapply_1b(objs, is.data.table))
6464
if (length(w)) {
65-
found_items = lapply(w, function(i) list(name=names[i], obj=obj[[i]]))
65+
found_items = lapply(w, function(i) list(name=names[i], obj=objs[[i]]))
6666
}
6767
}
6868
if (!length(found_items)) {

inst/tests/tests.Rraw

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21549,7 +21549,7 @@ local({
2154921549
"lst_named$inner", "lst_unnamed[[1]]", "nested$l1$l2",
2155021550
"mixed[[1]]", "mixed$y",
2155121551
"mixed_nested$A[[1]]", "mixed_nested$A$q")
21552-
test(2335.1, out, expected)
21552+
test(2335.1, out, sort(expected))
2155321553
})
2155421554
local({
2155521555
dt <- data.table(val=42)
@@ -21568,5 +21568,5 @@ local({
2156821568
out <- tables(recursive=TRUE)$NAME
2156921569
test(2335.3, length(out), 2L)
2157021570
test(2335.4, "test_obj$unique" %in% out)
21571-
test(2335.5, sum(endsWith(out, "$dt_inner")), 1L)
21571+
test(2335.5, sum(grepl("\\$dt_inner$", out)), 1L)
2157221572
})

0 commit comments

Comments
 (0)