Merge branch 'master' into froll-n0

Author: jangorecki

src/uniqlist.c

@@ -150,12 +150,16 @@ SEXP uniqlengths(SEXP x, SEXP n) {
   // seems very similar to rbindlist.c:uniq_lengths. TODO: centralize into common function
   if (TYPEOF(x) != INTSXP) error(_("Input argument 'x' to 'uniqlengths' must be an integer vector"));
   if (TYPEOF(n) != INTSXP || length(n) != 1) error(_("Input argument 'n' to 'uniqlengths' must be an integer vector of length 1"));
-  R_len_t len = length(x);
+  const R_len_t len = length(x);
   SEXP ans = PROTECT(allocVector(INTSXP, len));
+
+  const int *px = INTEGER_RO(x);
+  int *pans = INTEGER(ans);
+
   for (R_len_t i=1; i<len; i++) {
-    INTEGER(ans)[i-1] = INTEGER(x)[i] - INTEGER(x)[i-1];
+      pans[i-1] = px[i] - px[i-1];
   }
-  if (len>0) INTEGER(ans)[len-1] = INTEGER(n)[0] - INTEGER(x)[len-1] + 1;
+  if (len>0) pans[len-1] = INTEGER(n)[0] - px[len-1] + 1;
   UNPROTECT(1);
   return(ans);
 }

src/utils.c

@@ -4,6 +4,7 @@ bool within_int32_repres(double x) {
   // N.B. (int)2147483647.99 is not undefined behaviour since s 6.3.1.4 of the C
   // standard states that behaviour is undefined only if the integral part of a
   // finite value of standard floating type cannot be represented.
+  // Also, note that these are not the same values you would get from INT32_MAX and INT32_MIN
   return R_FINITE(x) && x < 2147483648 && x > -2147483648;
 }