Refactored duplicated logic in setDT and [,:=] to use a helper function

nipun-gupta-3108 · nipun-gupta-3108 · commit cecfb0b269e3 · 2025-01-23T01:36:23.000+05:30
diff --git a/R/fmelt.R b/R/fmelt.R
@@ -184,7 +184,7 @@ melt.data.table = function(data, id.vars, measure.vars, variable.name = "variabl
   if (!is.data.table(data)) stopf("'data' must be a data.table")
 
   # Validate id.vars
-  if (any(is.na(id.vars) | id.vars == "")) {
+  if (any(is.na(id.vars) | !nzchar(id.vars))) {
     stopf("One or more values in 'id.vars' is invalid.")
   }
 

Original file line number	Diff line number	Diff line change
`@@ -184,7 +184,7 @@ melt.data.table = function(data, id.vars, measure.vars, variable.name = "variabl`
`184`	`184`	`if (!is.data.table(data)) stopf("'data' must be a data.table")`
`185`	`185`
`186`	`186`	`# Validate id.vars`
`187`		`- if (any(is.na(id.vars) \| id.vars == "")) {`
	`187`	`+ if (any(is.na(id.vars) \| !nzchar(id.vars))) {`
`188`	`188`	`stopf("One or more values in 'id.vars' is invalid.")`
`189`	`189`	`}`
`190`	`190`