Make it an error everywhere, not warning

Author: MichaelChirico

NAMESPACE

@@ -199,7 +199,6 @@ S3method(edit, data.table)
 export(format_col)
 S3method(format_col, default)
 S3method(format_col, POSIXct)
-S3method(format_col, POSIXlt)
 S3method(format_col, expression)
 export(format_list_item)
 S3method(format_list_item, default)

R/data.table.R

@@ -2918,15 +2918,13 @@ setDT = function(x, keep.rownames=FALSE, key=NULL, check.names=FALSE) {
   } else if (is.data.frame(x)) {
     # check no matrix-like columns, #3760. Allow a single list(matrix) is unambiguous and depended on by some revdeps, #3581
     # for performance, only warn on the first such column, #5426
-    test_matrix_column = test_posixl_column = TRUE
     for (jj in seq_along(x)) {
       if (test_posixl_column && inherits(x[[jj]], "POSIXlt")) {
-        .Call(Cwarn_posixl_column_r, jj)
-        test_posixl_column = FALSE
+        .Call(Cerr_posixl_column_r, jj)
       }
       if (test_matrix_column && length(dim(x[[jj]])) > 1L) {
         .Call(Cwarn_matrix_column_r, jj)
-        test_matrix_column = FALSE
+        break
       }
     }
 

R/print.data.table.R

@@ -213,11 +213,6 @@ format_col.POSIXct = function(x, ..., timezone=FALSE) {
   x
 }
 
-format_col.POSIXlt = function(x, ...) {
-  names(x) = names(unclass(as.POSIXlt(Sys.time())))
-  format_col(as.POSIXct(x), ...)
-}
-
 # #3011 -- expression columns can wrap to newlines which breaks printing
 format_col.expression = function(x, ...) format(char.trunc(as.character(x)), ...)
 

inst/tests/tests.Rraw

@@ -8655,7 +8655,7 @@ dt = data.table(d1="1984-03-17")
 ans = data.table(d1="1984-03-17", d2=as.POSIXct("1984-03-17", tz='UTC'))
 test(1612.2, dt[, d2 := strptime(d1, "%Y-%m-%d", tz='UTC')], ans, warning="POSIXlt detected and converted to POSIXct")
 ll = list(a=as.POSIXlt("2015-01-01"), b=2L)
-test(1612.3, setDT(ll), ll, warning="Column 1 has class 'POSIXlt'")
+test(1612.3, setDT(ll), error="Column 1 has class 'POSIXlt'")
 
 # tests for all.equal.data.table #1106
 # diff nrow

src/assign.c

@@ -203,16 +203,15 @@ void warn_matrix_column(/* 1-indexed */ int i) {
   warning(_("Some columns are a multi-column type (such as a matrix column), for example column %d. setDT will retain these columns as-is but subsequent operations like grouping and joining may fail. Please consider as.data.table() instead which will create a new column for each embedded column."), i);
 }
 
-void warn_posixl_column(/* 1-indexed */ int i) {
-  warning(_("Column %d has class 'POSIXlt'. setDT will retain these columns as-is but subsequent operations may fail. We do not recommend the use of POSIXlt at all because it uses 40 bytes to store one date. Please consider as.data.table() instead which will convert to POSIXct."), i);
+void err_posixl_column(/* 1-indexed */ int i) {
+  error(_("Column %d has class 'POSIXlt'. Please convert it to POSIXct (using as.POSIXct) and run setDT() again, or use as.data.table() instead. We do not recommend the use of POSIXlt at all because it uses 40 bytes to store one date."), i);
 }
 
 // input validation for setDT() list input; assume is.list(x) was tested in R
 SEXP setdt_nrows(SEXP x)
 {
   int base_length = 0;
   bool test_matrix_cols = true;
-  bool test_posixl_cols = true;
 
   for (R_len_t i = 0; i < LENGTH(x); ++i) {
     SEXP xi = VECTOR_ELT(x, i);
@@ -238,8 +237,7 @@ SEXP setdt_nrows(SEXP x)
       }
       len_xi = INTEGER(dim_xi)[0];
     } else {
-      // Be sure to do length() dispatch, #4800
-      len_xi = length_with_dispatch(xi);
+      len_xi = LENGTH(xi);
     }
     if (!base_length) {
       base_length = len_xi;

src/data.table.h

@@ -182,7 +182,7 @@ SEXP alloccol(SEXP dt, R_len_t n, Rboolean verbose);
 const char *memrecycle(const SEXP target, const SEXP where, const int start, const int len, SEXP source, const int sourceStart, const int sourceLen, const int colnum, const char *colname);
 SEXP shallowwrapper(SEXP dt, SEXP cols);
 void warn_matrix_column(int i);
-void warn_posixl_column(int i);
+void err_posixl_column(int i);
 
 SEXP dogroups(SEXP dt, SEXP dtcols, SEXP groups, SEXP grpcols, SEXP jiscols,
                 SEXP xjiscols, SEXP grporder, SEXP order, SEXP starts,
@@ -330,7 +330,7 @@ SEXP gfirst(SEXP);
 SEXP gnthvalue(SEXP, SEXP);
 SEXP dim(SEXP);
 SEXP warn_matrix_column_r(SEXP);
-SEXP warn_posixl_column_r(SEXP);
+SEXP err_posixl_column_r(SEXP);
 SEXP gvar(SEXP, SEXP);
 SEXP gsd(SEXP, SEXP);
 SEXP gprod(SEXP, SEXP);

src/init.c

@@ -151,7 +151,7 @@ R_CallMethodDef callMethods[] = {
 {"CconvertDate", (DL_FUNC)&convertDate, -1},
 {"Cnotchin", (DL_FUNC)&notchin, -1},
 {"Cwarn_matrix_column_r", (DL_FUNC)&warn_matrix_column_r, -1},
-{"Cwarn_posixl_column_r", (DL_FUNC)&warn_posixl_column_r, -1},
+{"Cerr_posixl_column_r", (DL_FUNC)&err_posixl_column_r, -1},
 {NULL, NULL, 0}
 };
 

src/wrappers.c

@@ -126,7 +126,7 @@ SEXP warn_matrix_column_r(SEXP i) {
   return R_NilValue;
 }
 
-SEXP warn_posixl_column_r(SEXP i) {
-  warn_posixl_column(INTEGER(i)[0]);
+SEXP err_posixl_column_r(SEXP i) {
+  err_posixl_column(INTEGER(i)[0]);
   return R_NilValue;
 }