More quality checks: any(!x)->!all(x); use vapply_1{b,c,i}

Author: MichaelChirico

R/mergelist.R

@@ -41,7 +41,7 @@ hasindex = function(x, by, retGrp=FALSE) {
 fdistinct = function(x, on=key(x), mult=c("first","last"), cols=seq_along(x), copy=TRUE) {
   if (!perhaps.data.table(x))
     stopf("'x' must be data.table")
-  if (!is.character(on) || !length(on) || anyNA(on) || any(!on%chin%names(x)))
+  if (!is.character(on) || !length(on) || anyNA(on) || !all(on %chin% names(x)))
     stopf("'on' must be character column names of 'x' argument")
   mult = match.arg(mult)
   if (is.null(cols))
@@ -242,11 +242,11 @@ mergelist = function(l, on, cols, how=c("left","inner","full","right","semi","an
   {
     if (!is.list(l) || is.data.frame(l))
       stopf("'l' must be a list")
-    if (any(!vapply(l, is.data.table, FALSE)))
+    if (!all(vapply_1b(l, is.data.table)))
       stopf("Every element of 'l' list must be data.table objects")
-    if (any(!vapply(l, length, 0L)))
+    if (!all(lengths(l)))
       stopf("Tables in 'l' argument must be non-zero columns tables")
-    if (any(vapply(l, function(x) anyDuplicated(names(x)), 0L)))
+    if (any(vapply_1i(l, function(x) anyDuplicated(names(x)))))
       stopf("Some of the tables in 'l' have duplicated column names")
   } ## l
   if (!isTRUEorFALSE(copy))
@@ -262,23 +262,23 @@ mergelist = function(l, on, cols, how=c("left","inner","full","right","semi","an
   {
     if (!is.list(join.many))
       join.many = rep(list(join.many), n-1L)
-    if (length(join.many)!=n-1L || any(!vapply(join.many, isTRUEorFALSE, NA)))
+    if (length(join.many)!=n-1L || !all(vapply_1b(join.many, isTRUEorFALSE)))
       stopf("'join.many' must be TRUE or FALSE, or a list of such which length must be length(l)-1L")
   } ## join.many
   {
     if (missing(mult))
       mult = NULL
     if (!is.list(mult))
       mult = rep(list(mult), n-1L)
-    if (length(mult)!=n-1L || any(!vapply(mult, function(x) is.null(x) || (is.character(x) && length(x)==1L && !anyNA(x) && x%chin%c("error","all","first","last")), NA)))
+    if (length(mult)!=n-1L || !all(vapply_1b(mult, function(x) is.null(x) || (is.character(x) && length(x)==1L && !anyNA(x) && x %chin% c("error","all","first","last")))))
       stopf("'mult' must be one of [error, all, first, last] or NULL, or a list of such which length must be length(l)-1L")
   } ## mult
   {
     if (missing(how) || is.null(how))
       how = match.arg(how)
     if (!is.list(how))
       how = rep(list(how), n-1L)
-    if (length(how)!=n-1L || any(!vapply(how, function(x) is.character(x) && length(x)==1L && !anyNA(x) && x%chin%c("left","inner","full","right","semi","anti","cross"), NA)))
+    if (length(how)!=n-1L || !all(vapply_1b(how, function(x) is.character(x) && length(x)==1L && !anyNA(x) && x %chin% c("left","inner","full","right","semi","anti","cross"))))
       stopf("'how' must be one of [left, inner, full, right, semi, anti, cross], or a list of such which length must be length(l)-1L")
   } ## how
   {
@@ -289,10 +289,10 @@ mergelist = function(l, on, cols, how=c("left","inner","full","right","semi","an
         stopf("'%s' must be a list", "cols")
       if (length(cols) != n)
         stopf("'cols' must be same length as 'l'")
-      skip = vapply(cols, is.null, FALSE)
-      if (any(!vapply(cols[!skip], function(x) is.character(x) && !anyNA(x) && !anyDuplicated(x), NA)))
+      skip = vapply_1b(cols, is.null)
+      if (!all(vapply_1b(cols[!skip], function(x) is.character(x) && !anyNA(x) && !anyDuplicated(x))))
         stopf("'cols' must be a list of non-zero length, non-NA, non-duplicated, character vectors, or eventually NULLs (all columns)")
-      if (any(mapply(function(x, icols) any(!icols %chin% names(x)), l[!skip], cols[!skip])))
+      if (any(mapply(function(x, icols) !all(icols %chin% names(x)), l[!skip], cols[!skip])))
         stopf("'cols' specify columns not present in corresponding table")
     }
   } ## cols
@@ -302,7 +302,7 @@ mergelist = function(l, on, cols, how=c("left","inner","full","right","semi","an
     } else {
       if (!is.list(on))
         on = rep(list(on), n-1L)
-      if (length(on)!=n-1L || any(!vapply(on, function(x) is.character(x) && !anyNA(x) && !anyDuplicated(x), NA))) ## length checked in dtmerge
+      if (length(on)!=n-1L || !all(vapply_1b(on, function(x) is.character(x) && !anyNA(x) && !anyDuplicated(x)))) ## length checked in dtmerge
         stopf("'on' must be non-NA, non-duplicated, character vector, or a list of such which length must be length(l)-1L")
     }
   } ## on
@@ -323,7 +323,7 @@ mergelist = function(l, on, cols, how=c("left","inner","full","right","semi","an
     )
     out.cols = copy(names(out))
   }
-  out.mem = vapply(out, address, "")
+  out.mem = vapply_1c(out, address)
   if (copy)
     .Call(CcopyCols, out, colnamesInt(out, names(out.mem)[out.mem %chin% unique(unlist(l.mem, recursive=FALSE))]))
   if (verbose)