Release Checks 1.18.0

[TysonStanley]

Issue for tracking release checks and communication with CRAN for the 1.18.0 release process.

[TysonStanley]

Feedback from Kurt include fixing this NOTE we get now:

Found the following (possibly) invalid file URI:
  URI: ./GOVERNANCE.md
    From: README.md

But he is triggering the other checks now so this will need to happen in our next patch release.

[MichaelChirico]

Feedback from Kurt include fixing this NOTE we get now:

Found the following (possibly) invalid file URI:
  URI: ./GOVERNANCE.md
    From: README.md

But he is triggering the other checks now so this will need to happen in our next patch release.

makes sense... that file's not in the package:

data.table/.Rbuildignore

Line 32 in 070c338

^GOVERNANCE\.md$

[TysonStanley]

The revdep check from CRAN included 39 packages:

CAST CausalGPS DramaAnalysis EIX ParBayesianOptimization SeaVal VIM
  autostats bbotk blocking cheapr circhelp collapse ctsem dblr
  forecastML gmwmx2 heatwaveR hicp inTrees insurancerating irace metR
  mlr3tuning myClim nlpred pmml popEpi qs rworkflows sarp.snowprofile
  sarp.snowprofile.alignment shinySbm slim tidyrules tidytable triact
  ume vardpoor webtrackR

Of these, locally I found that 19 were valid (ignore link in table, it is to a md on my machine):

package	version	error	warning	note	In revdep?	revdep issue	Fixed?
bbotk	1.8.1	+1			❌	#7498	✅
blocking	1.0.1	+1			✅	#7498	✅
circhelp	1.1	+1	1	1	✅	#7498	✅
ctsem	3.10.4	+1	1		❌	#7506
DramaAnalysis	3.0.2	+2			✅	#7498	✅
hicp	1.0.0	+2			✅	#7498	✅
irace	4.3	+1			❌	#7501	✅
metR	0.18.3	+2			✅	#7498	✅
mlr3tuning	1.5.1	+1	1		❌	#7498	✅
myClim	1.5.0	+1	1		❌	filed revdep PR	❌
popEpi	0.4.13	+1			✅	#7501	✅
SeaVal	1.2.0	+1	1		✅	#7498	✅
slim	0.1.1	+1		1	❌	#7498	✅
tidyrules	0.2.7	+2			✅	#7498	✅
tidytable	0.11.2	+1			❌	#7498	✅
triact	0.3.1	+2			❌	#7503	✅
ume	1.5.2	+1			❌	#7498	✅
vardpoor	0.20.1	+1		2	✅	filed revdep PR	❌
webtrackR	0.3.1	+1			❌	#7498	✅

[Polkas]

There is much more packages which are exposed to the data.table vs R devel 198 problem. Like flextable and my package (I am maintainer) gridify which depends on flextable. data.table problem blocked me to resubmit after getting a problem from another package. The end of the year is not calm:( Thank you guys for your work on the update.

[ben-schwen]

heatwaveR and maditr have been fixed in their repo but not submitted to CRAN yet.

[MichaelChirico]

Problem in {myClim} is pretty deeply nested. I've isolated it to this test, but don't see the link to {data.table} yet:

https://github.com/ibot-geoecology/myClim/blob/6e0c93c2c9462cd8bc016dd34b1e41575cab87fd/tests/testthat/test-calc.R#L137

[TysonStanley]

Problem in {myClim} is pretty deeply nested. I've isolated it to this test, but don't see the link to {data.table} yet:

https://github.com/ibot-geoecology/myClim/blob/6e0c93c2c9462cd8bc016dd34b1e41575cab87fd/tests/testthat/test-calc.R#L137

This one is weird. I see a lot of rlang and tibble. data.table only seems to be used for frollapply() and frollmean() https://github.com/search?q=repo%3Aibot-geoecology%2FmyClim%20data.table&type=code. Makes me wonder if there a false positive in this one.

[ben-schwen]

Problem in {myClim} is pretty deeply nested. I've isolated it to this test, but don't see the link to {data.table} yet:

https://github.com/ibot-geoecology/myClim/blob/6e0c93c2c9462cd8bc016dd34b1e41575cab87fd/tests/testthat/test-calc.R#L137

I tested with 1.17.8 and got the same two errors, so I would guess we are not the problem for the errors.

[TysonStanley]

Problem in {myClim} is pretty deeply nested. I've isolated it to this test, but don't see the link to {data.table} yet:
https://github.com/ibot-geoecology/myClim/blob/6e0c93c2c9462cd8bc016dd34b1e41575cab87fd/tests/testthat/test-calc.R#L137

I tested with 1.17.8 and got the same two errors, so I would guess we are not the problem for the errors.

There are often at least one or two of these that pop up so think we can scratch this one off the list.

[TysonStanley]

For {vardpoor} it looks like it in this line where the error pops up: https://github.com/CSBLatvia/vardpoor/blob/28ed111890370be34b2ccc3d2e4d5325d4b631c8/vardpoor/R/vardannual.R#L698

Running examples in ‘vardpoor-Ex.R’ failed
The error most likely occurred in:

> ### Name: vardannual
> ### Title: Variance estimation for measures of annual net change or annual
> ###   for single and multistage stage cluster sampling designs
> ### Aliases: vardannual
> ### Keywords: vardannual
> 
> ### ** Examples
...
> vardannual(Y = "employed", H = "strata",
+            PSU = "PSU", w_final = "rb050",
+            ID_level1 = "db030", ID_level2 = "id_lv2",
+            Dom = NULL, Z = NULL, years = "year",
+            subperiods = "half", dataset = dataset1,
+            percentratio = 100, confidence = 0.95,
+            method = "cros")
Error in t(X) %*% A_matrix : non-conformable arguments
Calls: vardannual -> lapply -> FUN -> data.table
Execution halted

Any ideas why that would have to do with our update? It happens inside of a data.table but don't see how data.table drives it. Might be another false positive?