Made fields readonly.

KN4CK3R · KN4CK3R · commit 6940a8f6190e · 2017-01-19T14:01:31.000+01:00
diff --git a/Core/InternalCoreFunctions.cs b/Core/InternalCoreFunctions.cs
@@ -8,7 +8,7 @@ internal class InternalCoreFunctions : NativeCoreWrapper
 		[return: MarshalAs(UnmanagedType.I1)]
 		private delegate bool DisassembleCodeDelegate(IntPtr address, IntPtr length, IntPtr virtualAddress, out InstructionData instruction);
 
-		private DisassembleCodeDelegate disassembleCodeDelegate;
+		private readonly DisassembleCodeDelegate disassembleCodeDelegate;
 
 		public InternalCoreFunctions(IntPtr handle)
 			: base(handle)
diff --git a/Core/NativeCoreWrapper.cs b/Core/NativeCoreWrapper.cs
@@ -42,19 +42,19 @@ public class NativeCoreWrapper : ICoreProcessFunctions
 		[return: MarshalAs(UnmanagedType.I1)]
 		private delegate bool SetHardwareBreakpointDelegate(IntPtr id, IntPtr address, HardwareBreakpointRegister register, HardwareBreakpointTrigger trigger, HardwareBreakpointSize size, [param: MarshalAs(UnmanagedType.I1)] bool set);
 
-		private EnumerateProcessesDelegate enumerateProcessesDelegate;
-		private EnumerateRemoteSectionsAndModulesDelegate enumerateRemoteSectionsAndModulesDelegate;
-		private OpenRemoteProcessDelegate openRemoteProcessDelegate;
-		private IsProcessValidDelegate isProcessValidDelegate;
-		private CloseRemoteProcessDelegate closeRemoteProcessDelegate;
-		private ReadRemoteMemoryDelegate readRemoteMemoryDelegate;
-		private WriteRemoteMemoryDelegate writeRemoteMemoryDelegate;
-		private ControlRemoteProcessDelegate controlRemoteProcessDelegate;
-		private AttachDebuggerToProcessDelegate attachDebuggerToProcessDelegate;
-		private DetachDebuggerFromProcessDelegate detachDebuggerFromProcessDelegate;
-		private AwaitDebugEventDelegate awaitDebugEventDelegate;
-		private HandleDebugEventDelegate handleDebugEventDelegate;
-		private SetHardwareBreakpointDelegate setHardwareBreakpointDelegate;
+		private readonly EnumerateProcessesDelegate enumerateProcessesDelegate;
+		private readonly EnumerateRemoteSectionsAndModulesDelegate enumerateRemoteSectionsAndModulesDelegate;
+		private readonly OpenRemoteProcessDelegate openRemoteProcessDelegate;
+		private readonly IsProcessValidDelegate isProcessValidDelegate;
+		private readonly CloseRemoteProcessDelegate closeRemoteProcessDelegate;
+		private readonly ReadRemoteMemoryDelegate readRemoteMemoryDelegate;
+		private readonly WriteRemoteMemoryDelegate writeRemoteMemoryDelegate;
+		private readonly ControlRemoteProcessDelegate controlRemoteProcessDelegate;
+		private readonly AttachDebuggerToProcessDelegate attachDebuggerToProcessDelegate;
+		private readonly DetachDebuggerFromProcessDelegate detachDebuggerFromProcessDelegate;
+		private readonly AwaitDebugEventDelegate awaitDebugEventDelegate;
+		private readonly HandleDebugEventDelegate handleDebugEventDelegate;
+		private readonly SetHardwareBreakpointDelegate setHardwareBreakpointDelegate;
 
 		#endregion
 
diff --git a/DataExchange/ReClassNetFile.cs b/DataExchange/ReClassNetFile.cs
@@ -48,7 +48,7 @@ public ReClassNetFile(ReClassNetProject project)
 			this.project = project;
 		}
 
-		private static Dictionary<string, Type> BuildInStringToTypeMap = new Type[]
+		private static readonly Dictionary<string, Type> BuildInStringToTypeMap = new[]
 		{
 			typeof(BoolNode),
 			typeof(BitFieldNode),
@@ -86,6 +86,6 @@ public ReClassNetFile(ReClassNetProject project)
 			typeof(Vector4Node),
 			typeof(VTableNode)
 		}.ToDictionary(t => t.Name, t => t);
-		private static Dictionary<Type, string> BuildInTypeToStringMap = BuildInStringToTypeMap.ToDictionary(kv => kv.Value, kv => kv.Key);
+		private static readonly Dictionary<Type, string> BuildInTypeToStringMap = BuildInStringToTypeMap.ToDictionary(kv => kv.Value, kv => kv.Key);
 	}
 }
diff --git a/Forms/FoundCodeForm.cs b/Forms/FoundCodeForm.cs
@@ -25,7 +25,7 @@ private class FoundCodeInfo
 
 		private readonly RemoteProcess process;
 		
-		private DataTable data;
+		private readonly DataTable data;
 		private volatile bool acceptNewRecords = true;
 
 		public event StopEventHandler Stop;
diff --git a/Native/NativeMethods.cs b/Native/NativeMethods.cs
@@ -6,7 +6,7 @@ namespace ReClassNET.Native
 {
 	public static class NativeMethods
 	{
-		private static INativeMethods nativeMethods;
+		private static readonly INativeMethods nativeMethods;
 
 		static NativeMethods()
 		{
diff --git a/Nodes/Matrix3x3Node.cs b/Nodes/Matrix3x3Node.cs
@@ -10,23 +10,23 @@ public class Matrix3x3Node : BaseMatrixNode
 		struct Matrix3x3Data
 		{
 			[FieldOffset(0)]
-			public float _11;
+			public readonly float _11;
 			[FieldOffset(4)]
-			public float _12;
+			public readonly float _12;
 			[FieldOffset(8)]
-			public float _13;
+			public readonly float _13;
 			[FieldOffset(12)]
-			public float _21;
+			public readonly float _21;
 			[FieldOffset(16)]
-			public float _22;
+			public readonly float _22;
 			[FieldOffset(20)]
-			public float _23;
+			public readonly float _23;
 			[FieldOffset(24)]
-			public float _31;
+			public readonly float _31;
 			[FieldOffset(28)]
-			public float _32;
+			public readonly float _32;
 			[FieldOffset(32)]
-			public float _33;
+			public readonly float _33;
 		}
 
 		/// <summary>Size of the node in bytes.</summary>
@@ -71,7 +71,7 @@ public override int Draw(ViewInfo view, int x2, int y2)
 				x = AddText(view, x, y, view.Settings.ValueColor, 7, $"{value._32,14:0.000}");
 				x = AddText(view, x, y, view.Settings.NameColor, HotSpot.NoneId, ",");
 				x = AddText(view, x, y, view.Settings.ValueColor, 8, $"{value._33,14:0.000}");
-				x = AddText(view, x, y, view.Settings.NameColor, HotSpot.NoneId, "|");
+				AddText(view, x, y, view.Settings.NameColor, HotSpot.NoneId, "|");
 			});
 		}
 
diff --git a/Nodes/Matrix3x4Node.cs b/Nodes/Matrix3x4Node.cs
@@ -9,29 +9,29 @@ public class Matrix3x4Node : BaseMatrixNode
 		struct Matrix3x4Data
 		{
 			[FieldOffset(0)]
-			public float _11;
+			public readonly float _11;
 			[FieldOffset(4)]
-			public float _12;
+			public readonly float _12;
 			[FieldOffset(8)]
-			public float _13;
+			public readonly float _13;
 			[FieldOffset(12)]
-			public float _14;
+			public readonly float _14;
 			[FieldOffset(16)]
-			public float _21;
+			public readonly float _21;
 			[FieldOffset(20)]
-			public float _22;
+			public readonly float _22;
 			[FieldOffset(24)]
-			public float _23;
+			public readonly float _23;
 			[FieldOffset(28)]
-			public float _24;
+			public readonly float _24;
 			[FieldOffset(32)]
-			public float _31;
+			public readonly float _31;
 			[FieldOffset(36)]
-			public float _32;
+			public readonly float _32;
 			[FieldOffset(40)]
-			public float _33;
+			public readonly float _33;
 			[FieldOffset(44)]
-			public float _34;
+			public readonly float _34;
 		}
 
 		/// <summary>Size of the node in bytes.</summary>
@@ -82,7 +82,7 @@ public override int Draw(ViewInfo view, int x2, int y2)
 				x = AddText(view, x, y, view.Settings.ValueColor, 10, $"{value._33,14:0.000}");
 				x = AddText(view, x, y, view.Settings.NameColor, HotSpot.NoneId, ",");
 				x = AddText(view, x, y, view.Settings.ValueColor, 11, $"{value._34,14:0.000}");
-				x = AddText(view, x, y, view.Settings.NameColor, HotSpot.NoneId, "|");
+				AddText(view, x, y, view.Settings.NameColor, HotSpot.NoneId, "|");
 			});
 		}
 
diff --git a/Nodes/Matrix4x4Node.cs b/Nodes/Matrix4x4Node.cs
@@ -9,37 +9,37 @@ public class Matrix4x4Node : BaseMatrixNode
 		struct Matrix4x4Data
 		{
 			[FieldOffset(0)]
-			public float _11;
+			public readonly float _11;
 			[FieldOffset(4)]
-			public float _12;
+			public readonly float _12;
 			[FieldOffset(8)]
-			public float _13;
+			public readonly float _13;
 			[FieldOffset(12)]
-			public float _14;
+			public readonly float _14;
 			[FieldOffset(16)]
-			public float _21;
+			public readonly float _21;
 			[FieldOffset(20)]
-			public float _22;
+			public readonly float _22;
 			[FieldOffset(24)]
-			public float _23;
+			public readonly float _23;
 			[FieldOffset(28)]
-			public float _24;
+			public readonly float _24;
 			[FieldOffset(32)]
-			public float _31;
+			public readonly float _31;
 			[FieldOffset(36)]
-			public float _32;
+			public readonly float _32;
 			[FieldOffset(40)]
-			public float _33;
+			public readonly float _33;
 			[FieldOffset(44)]
-			public float _34;
+			public readonly float _34;
 			[FieldOffset(48)]
-			public float _41;
+			public readonly float _41;
 			[FieldOffset(52)]
-			public float _42;
+			public readonly float _42;
 			[FieldOffset(56)]
-			public float _43;
+			public readonly float _43;
 			[FieldOffset(60)]
-			public float _44;
+			public readonly float _44;
 		}
 
 		/// <summary>Size of the node in bytes.</summary>
diff --git a/Nodes/Vector2Node.cs b/Nodes/Vector2Node.cs
@@ -9,9 +9,9 @@ public class Vector2Node : BaseMatrixNode
 		struct Vector2Data
 		{
 			[FieldOffset(0)]
-			public float X;
+			public readonly float X;
 			[FieldOffset(4)]
-			public float Y;
+			public readonly float Y;
 		}
 
 		/// <summary>Size of the node in bytes.</summary>
diff --git a/Nodes/Vector3Node.cs b/Nodes/Vector3Node.cs
@@ -9,11 +9,11 @@ public class Vector3Node : BaseMatrixNode
 		struct Vector3Data
 		{
 			[FieldOffset(0)]
-			public float X;
+			public readonly float X;
 			[FieldOffset(4)]
-			public float Y;
+			public readonly float Y;
 			[FieldOffset(8)]
-			public float Z;
+			public readonly float Z;
 		}
 
 		/// <summary>Size of the node in bytes.</summary>
diff --git a/Nodes/Vector4Node.cs b/Nodes/Vector4Node.cs
@@ -9,13 +9,13 @@ public class Vector4Node : BaseMatrixNode
 		struct Vector4Data
 		{
 			[FieldOffset(0)]
-			public float X;
+			public readonly float X;
 			[FieldOffset(4)]
-			public float Y;
+			public readonly float Y;
 			[FieldOffset(8)]
-			public float Z;
+			public readonly float Z;
 			[FieldOffset(12)]
-			public float W;
+			public readonly float W;
 		}
 
 		/// <summary>Size of the node in bytes.</summary>
diff --git a/Settings.cs b/Settings.cs
@@ -117,8 +117,7 @@ public static void Save(Settings settings, string filename)
 		[XmlElement(Type = typeof(XmlColorWrapper))]
 		public Color CustomColor { get; set; } = Color.FromArgb(64, 128, 64);
 
-		private static Color[] highlightColors = new Color[]
-		{
+		private static readonly Color[] highlightColors = {
 			Color.Aqua, Color.Aquamarine, Color.Blue, Color.BlueViolet, Color.Chartreuse, Color.Crimson, Color.LawnGreen, Color.Magenta
 		};
 		[XmlIgnore]

Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ public ReClassNetFile(ReClassNetProject project)`
`48`	`48`	`this.project = project;`
`49`	`49`	`}`
`50`	`50`
`51`		`- private static Dictionary<string, Type> BuildInStringToTypeMap = new Type[]`
	`51`	`+ private static readonly Dictionary<string, Type> BuildInStringToTypeMap = new[]`
`52`	`52`	`{`
`53`	`53`	`typeof(BoolNode),`
`54`	`54`	`typeof(BitFieldNode),`
`@@ -86,6 +86,6 @@ public ReClassNetFile(ReClassNetProject project)`
`86`	`86`	`typeof(Vector4Node),`
`87`	`87`	`typeof(VTableNode)`
`88`	`88`	`}.ToDictionary(t => t.Name, t => t);`
`89`		`- private static Dictionary<Type, string> BuildInTypeToStringMap = BuildInStringToTypeMap.ToDictionary(kv => kv.Value, kv => kv.Key);`
	`89`	`+ private static readonly Dictionary<Type, string> BuildInTypeToStringMap = BuildInStringToTypeMap.ToDictionary(kv => kv.Value, kv => kv.Key);`
`90`	`90`	`}`
`91`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@ namespace ReClassNET.Native`
`6`	`6`	`{`
`7`	`7`	`public static class NativeMethods`
`8`	`8`	`{`
`9`		`- private static INativeMethods nativeMethods;`
	`9`	`+ private static readonly INativeMethods nativeMethods;`
`10`	`10`
`11`	`11`	`static NativeMethods()`
`12`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -9,9 +9,9 @@ public class Vector2Node : BaseMatrixNode`
`9`	`9`	`struct Vector2Data`
`10`	`10`	`{`
`11`	`11`	`[FieldOffset(0)]`
`12`		`- public float X;`
	`12`	`+ public readonly float X;`
`13`	`13`	`[FieldOffset(4)]`
`14`		`- public float Y;`
	`14`	`+ public readonly float Y;`
`15`	`15`	`}`
`16`	`16`
`17`	`17`	`/// <summary>Size of the node in bytes.</summary>`
Original file line number	Diff line number	Diff line change
`@@ -9,11 +9,11 @@ public class Vector3Node : BaseMatrixNode`
`9`	`9`	`struct Vector3Data`
`10`	`10`	`{`
`11`	`11`	`[FieldOffset(0)]`
`12`		`- public float X;`
	`12`	`+ public readonly float X;`
`13`	`13`	`[FieldOffset(4)]`
`14`		`- public float Y;`
	`14`	`+ public readonly float Y;`
`15`	`15`	`[FieldOffset(8)]`
`16`		`- public float Z;`
	`16`	`+ public readonly float Z;`
`17`	`17`	`}`
`18`	`18`
`19`	`19`	`/// <summary>Size of the node in bytes.</summary>`