Give plugins a chance to fail while reading a node.

Author: KN4CK3R

DataExchange/CustomNodeConverter.cs

@@ -21,17 +21,19 @@ public interface ICustomNodeConverter
 		/// <returns>True if the instance can handle the node, false if not.</returns>
 		bool CanHandleNode(BaseNode node);
 
-		/// <summary>Creates a schema node from the xml element. This method gets only called if <see cref="CanHandleElement(XElement)"/> returned true.</summary>
-		/// <param name="element">The element to create the schema from.</param>
-		/// <param name="classes">The list of classes which correspond to the schema.</param>
+		/// <summary>Creates a node from the xml element. This method gets only called if <see cref="CanHandleElement(XElement)"/> returned true.</summary>
+		/// <param name="element">The element to create the node from.</param>
+		/// <param name="parent">The parent of the node.</param>
+		/// <param name="classes">The list of classes which correspond to the node.</param>
 		/// <param name="logger">The logger used to output messages.</param>
-		/// <returns>The schema node for the xml element.</returns>
-		BaseNode CreateNodeFromElement(XElement element, ClassNode parent, IEnumerable<ClassNode> classes, ILogger logger);
+		/// <param name="node">[out] The node for the xml element.</param>
+		/// <returns>True if a node was created, otherwise false.</returns>
+		bool TryCreateNodeFromElement(XElement element, ClassNode parent, IEnumerable<ClassNode> classes, ILogger logger, out BaseNode node);
 
-		/// <summary>Creates a xml element from the schema node. This method gets only called if <see cref="CanHandleSchema(SchemaCustomNode)"/> returned true.</summary>
-		/// <param name="node">The schema node to create the xml element from.</param>
+		/// <summary>Creates a xml element from the node. This method gets only called if <see cref="CanHandleNode(BaseNode node)"/> returned true.</summary>
+		/// <param name="node">The node to create the xml element from.</param>
 		/// <param name="logger">The logger used to output messages.</param>
-		/// <returns>The xml element for the schema node.</returns>
+		/// <returns>The xml element for the node.</returns>
 		XElement CreateElementFromNode(BaseNode node, ILogger logger);
 	}
 
@@ -52,15 +54,14 @@ public bool CanHandleNode(BaseNode node)
 			throw new NotImplementedException();
 		}
 
-		public BaseNode CreateNodeFromElement(XElement element, ClassNode parent, IEnumerable<ClassNode> classes, ILogger logger)
+		public bool TryCreateNodeFromElement(XElement element, ClassNode parent, IEnumerable<ClassNode> classes, ILogger logger, out BaseNode node)
 		{
 			Contract.Requires(element != null);
 			Contract.Requires(CanHandleElement(element));
 			Contract.Requires(parent != null);
 			Contract.Requires(classes != null);
 			Contract.Requires(Contract.ForAll(classes, c => c != null));
 			Contract.Requires(logger != null);
-			Contract.Ensures(Contract.Result<BaseNode>() != null);
 
 			throw new NotImplementedException();
 		}

DataExchange/ReClassNetFile.Read.cs

@@ -84,7 +84,11 @@ private IEnumerable<BaseNode> ReadNodeElements(IEnumerable<XElement> elements, C
 				var converter = CustomNodeConvert.GetReadConverter(element);
 				if (converter != null)
 				{
-					yield return converter.CreateNodeFromElement(element, parent, project.Classes, logger);
+					BaseNode customNode;
+					if (converter.TryCreateNodeFromElement(element, parent, project.Classes, logger, out customNode))
+					{
+						yield return customNode;
+					}
 
 					continue;
 				}

DataExchange/ReClassNetFile.Write.cs

@@ -78,7 +78,7 @@ private IEnumerable<XElement> CreateNodeElements(IEnumerable<BaseNode> nodes, IL
 				string typeString;
 				if (!BuildInTypeToStringMap.TryGetValue(node.GetType(), out typeString))
 				{
-					logger.Log(LogLevel.Error, $"Skipping node with unknown type converter: {node.Name}");
+					logger.Log(LogLevel.Error, $"Skipping node with unknown type: {node.Name}");
 					logger.Log(LogLevel.Warning, node.GetType().ToString());
 
 					continue;

DataExchange/ReClassNetFile.cs

@@ -22,21 +22,21 @@ public partial class ReClassNetFile : IReClassImport, IReClassExport
 
 		private const string SerialisationClassName = "__Serialization_Class__";
 
-		private const string XmlRootElement = "reclass";
-		private const string XmlClassesElement = "classes";
-		private const string XmlClassElement = "class";
-		private const string XmlNodeElement = "node";
-		private const string XmlMethodElement = "method";
-		private const string XmlVersionAttribute = "version";
-		private const string XmlUuidAttribute = "uuid";
-		private const string XmlNameAttribute = "name";
-		private const string XmlCommentAttribute = "comment";
-		private const string XmlAddressAttribute = "address";
-		private const string XmlTypeAttribute = "type";
-		private const string XmlReferenceAttribute = "reference";
-		private const string XmlCountAttribute = "count";
-		private const string XmlBitsAttribute = "bits";
-		private const string XmlLengthAttribute = "length";
+		public const string XmlRootElement = "reclass";
+		public const string XmlClassesElement = "classes";
+		public const string XmlClassElement = "class";
+		public const string XmlNodeElement = "node";
+		public const string XmlMethodElement = "method";
+		public const string XmlVersionAttribute = "version";
+		public const string XmlUuidAttribute = "uuid";
+		public const string XmlNameAttribute = "name";
+		public const string XmlCommentAttribute = "comment";
+		public const string XmlAddressAttribute = "address";
+		public const string XmlTypeAttribute = "type";
+		public const string XmlReferenceAttribute = "reference";
+		public const string XmlCountAttribute = "count";
+		public const string XmlBitsAttribute = "bits";
+		public const string XmlLengthAttribute = "length";
 
 		private ReClassNetProject project;