Fixing Bad Request response for term group creation.

Author: krulis-martin

app/presenters/GroupsPresenter.php

@@ -63,15 +63,15 @@ private function isGroupSuitableForTerm(array $groups, string $groupId, string $
 
         $group = $groups[$groupId];
         if (!$group->hasCourseAttribute()) {
-            throw new ForbiddenRequestException("Group $groupId does not have any course attributes.");
+            throw new BadRequestException("Group $groupId does not have any course attributes.");
         }
         if ($group->hasTermAttribute()) {
-            throw new ForbiddenRequestException("Group $groupId have term attributes.");
+            throw new BadRequestException("Group $groupId have term attributes.");
         }
 
         foreach ($groups as $group) {
             if ($group->parentGroupId === $groupId && $group->hasTermAttribute($term)) {
-                throw new ForbiddenRequestException(
+                throw new BadRequestException(
                     "One of the children of group $groupId already have associated term $term."
                 );
             }

tests/Presenters/GroupsPresenter.phpt

@@ -903,7 +903,7 @@ class TestGroupsPresenter extends Tester\TestCase
                 ['action' => 'createTerm', 'parentId' => 'c1', 'term' => '2025-1'],
                 ['texts' => $texts]
             );
-        }, ForbiddenRequestException::class);
+        }, BadRequestException::class);
     }
 
     public function testCreateTermGroupAlreadyExist()
@@ -938,7 +938,7 @@ class TestGroupsPresenter extends Tester\TestCase
                 ['action' => 'createTerm', 'parentId' => 'c1', 'term' => '2025-1'],
                 ['texts' => $texts]
             );
-        }, ForbiddenRequestException::class);
+        }, BadRequestException::class);
     }
 
     public function testAddAttribute()