Warn when page.date hasn't been updated (except for index and special pages).

Author: ReFreezed

examples/apache/content/404.md

@@ -1,5 +1,6 @@
 {{
-page.title = "Error 404: Not Found"
+page.title     = "Error 404: Not Found"
+page.isSpecial = true
 }}
 
 # {{ page.title }}

src/app.lua2p

@@ -1375,7 +1375,7 @@ local function buildWebsite()
 
 		assertFunc(v, ...)
 
-		tLast[kLast] = nil -- Helps us find extra/unknown fields.
+		tLast[kLast] = nil -- Helps us find extra/unknown fields later.
 		return v
 	end
 
@@ -1440,10 +1440,10 @@ local function buildWebsite()
 	site._redirectionLayout       = getV("redirectionLayout", site._redirectionLayout, "string")
 
 	for k in pairs(config) do
-		timestampPrintWarning("Unknown config field '%s'.", k)
+		timestampPrintWarning("%s: Unknown config field '%s'.", maybeFullPath"config.lua", k)
 	end
 	for k in pairs(htaccess or {}) do
-		timestampPrintWarning("Unknown config.htaccess field '%s'.", k)
+		timestampPrintWarning("%s: Unknown config.htaccess field '%s'.", maybeFullPath"config.lua", k)
 	end
 
 	if not isAny(type(site._outputPathFormat), "string","function") then
@@ -1491,7 +1491,7 @@ local function buildWebsite()
 
 	-- Final config handling.
 	for ext, customDataParser in pairs(customDataTextParsers) do
-		-- ext = ext:lower() -- Actually a bad idea! (Until we have a version of isFile() that is case insensitive, that is.)
+		-- ext = ext:lower() -- Actually a bad idea! (Until we have a version of isFile() that is case insensitive, that is. Also, we should probably raise an error if it's not lowercase.)
 
 		dataParsers[ext]        = customDataParser
 		dataParserIsBinary[ext] = false
@@ -1502,7 +1502,7 @@ local function buildWebsite()
 	end
 
 	for ext, customDataParser in pairs(customDataBinaryParsers) do
-		-- ext = ext:lower() -- Actually a bad idea! (Until we have a version of isFile() that is case insensitive, that is.)
+		-- ext = ext:lower() -- Actually a bad idea! (Until we have a version of isFile() that is case insensitive, that is. Also, we should probably raise an error if it's not lowercase.)
 
 		dataParsers[ext]        = customDataParser
 		dataParserIsBinary[ext] = true

src/functions.lua2p

@@ -1075,7 +1075,12 @@ end
 -- timestampLog( formatString, ... )
 function _G.timestampLog(s, ...)
 	if select("#", ...) > 0 then  s = F(s, ...)  end
-	log("[%s] %s", os.date"%H:%M:%S", s)
+
+	if s == "" then
+		log("")
+	else
+		log("[%s] %s", os.date"%H:%M:%S", s)
+	end
 end
 
 -- timestampPrint( message )
@@ -1085,7 +1090,11 @@ end
 function _G.timestampPrint(s, ...)
 	if select("#", ...) > 0 then  s = F(s, ...)  end
 
-	printf("[%s] %s", os.date"%H:%M:%S", s)
+	if s == "" then
+		print()
+	else
+		printf("[%s] %s", os.date"%H:%M:%S", s)
+	end
 end
 function _G.timestampPrintOnce(s, ...)
 	if select("#", ...) > 0 then  s = F(s, ...)  end
@@ -1128,7 +1137,7 @@ function _G.timestampPrintWarning(s, ...)
 	_G.warningCount = warningCount + 1
 	s               = F("[%s] WARNING(%d): %s", os.date"%H:%M:%S", warningCount, s)
 
-	io.stderr:write(s, "\n")
+	io.stderr:write(s, "\n\n")
 	log(s)
 end
 function _G.timestampPrintWarningOnce(s, ...)
@@ -1140,7 +1149,7 @@ function _G.timestampPrintWarningOnce(s, ...)
 	_G.warningCount = warningCount + 1
 	s               = F("[%s] WARNING(%d): %s", os.date"%H:%M:%S", warningCount, s)
 
-	io.stderr:write(s, "\n")
+	io.stderr:write(s, "\n\n")
 	log(s)
 end
 
@@ -1777,6 +1786,11 @@ function _G.generateFromTemplateString(page, template, modTime, onPageInit)
 			return
 		end
 
+		if not (page.isIndex.v or page.isSpecial.v) and not page._dateHasBeenUpdated then
+			-- @UX: Should there be an option to disable this? Maybe an option for suppressing all warnings?
+			timestampPrintWarning("%s did not update page.date.", maybeFullPath(page._path))
+		end
+
 		page.content.v           = pageContent
 		page._contentIsAvailable = true
 
@@ -2341,6 +2355,7 @@ do
 			_isSkipped          = false,
 			_isLocked           = false, -- @Cleanup: Is this always synced with _readonly? If so, just remove _isLocked.
 			_contentIsAvailable = false,
+			_dateHasBeenUpdated = false,
 			_path               = pathRel,
 			_pathOut            = pathRelOut,
 			_pathForError       = maybeFullPath(F("%s/%s", DIR_CONTENT, pathRel)),
@@ -2390,7 +2405,7 @@ do
 			date = {
 				v = getDatetime(0),
 				g = function(field)  return field.v  end,
-				s = function(field, datetime)  field.v = datetime  end,
+				s = function(field, datetime)  field.v = datetime ; page._dateHasBeenUpdated = true  end,
 			},
 			dateModified = { -- This field currently isn't used anywhere internally - it just exists for the user's convenience. 2021-05-19
 				v = "",