Comments handling

Author: bakwc

mysql_ch_replicator/converter.py

@@ -1,5 +1,6 @@
 import json
 import sqlparse
+import re
 from pyparsing import Word, alphas, alphanums
 
 from .table_structure import TableStructure, TableField
@@ -369,7 +370,13 @@ def parse_create_table_query(self, mysql_query) -> tuple:
     def convert_drop_table_query(self, mysql_query):
         raise Exception('not implement')
 
+    def _strip_comments(self, create_statement):
+        pattern = r'\bCOMMENT(?:\s*=\s*|\s+)([\'"])(?:\\.|[^\\])*?\1'
+        return re.sub(pattern, '', create_statement, flags=re.IGNORECASE)
+
     def parse_mysql_table_structure(self, create_statement, required_table_name=None):
+        create_statement = self._strip_comments(create_statement)
+
         structure = TableStructure()
 
         tokens = sqlparse.parse(create_statement.replace('\n', ' ').strip())[0].tokens

test_mysql_ch_replicator.py

@@ -88,8 +88,8 @@ def test_e2e_regular():
     mysql.execute(f'''
 CREATE TABLE {TEST_TABLE_NAME} (
     id int NOT NULL AUTO_INCREMENT,
-    name varchar(255),
-    age int,
+    name varchar(255) COMMENT 'Dân tộc, ví dụ: Kinh',
+    age int COMMENT 'CMND Cũ',
     field1 text,
     field2 blob,
     PRIMARY KEY (id)