Skip to content

Commit b2084a1

Browse files
refactor: with lombok
1 parent ca1eab2 commit b2084a1

File tree

6 files changed

+10
-21
lines changed

6 files changed

+10
-21
lines changed

pom.xml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@
6060
<httpcore5.version>5.3.4</httpcore5.version>
6161
<junit.version>5.13.0</junit.version>
6262
<lombok.version>1.18.38</lombok.version>
63+
<maven.compiler.plugin.version>3.14.0</maven.compiler.plugin.version>
6364
<moshi.version>1.15.2</moshi.version>
6465
</properties>
6566

@@ -93,6 +94,7 @@
9394
<plugin>
9495
<groupId>org.apache.maven.plugins</groupId>
9596
<artifactId>maven-compiler-plugin</artifactId>
97+
<version>${maven.compiler.plugin.version}</version>
9698
<configuration>
9799
<annotationProcessorPaths>
98100
<path>
Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,16 @@
11
package dev.resms.config;
22

3+
import lombok.Getter;
4+
35
import java.net.http.HttpClient;
46
import java.time.Duration;
57

68
/**
79
* Configuration class for ReSMS SDK
810
*/
11+
@Getter
912
public class ReSMSConfig {
10-
private static final String BASE_URL = "https://api.resms.dev/";
13+
public static final String BASE_URL = "https://api.resms.dev/";
1114

1215
private final String apiKey;
1316
private final int timeoutSeconds;
@@ -20,20 +23,4 @@ public ReSMSConfig(String apiKey, int timeoutSeconds) {
2023
.connectTimeout(Duration.ofSeconds(timeoutSeconds))
2124
.build();
2225
}
23-
24-
public String getApiKey() {
25-
return apiKey;
26-
}
27-
28-
public int getTimeoutSeconds() {
29-
return timeoutSeconds;
30-
}
31-
32-
public String getBaseUrl() {
33-
return BASE_URL;
34-
}
35-
36-
public HttpClient getHttpClient() {
37-
return httpClient;
38-
}
3926
}

src/main/java/dev/resms/repository/SmsRepository.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public SendSmsResponse sendSms(SendSmsRequest requestBody) throws ReSMSException
5252
String jsonBody = requestAdapter.toJson(requestBody);
5353

5454
HttpRequest request = HttpRequest.newBuilder()
55-
.uri(URI.create(config.getBaseUrl() + SEND_SMS_PATH))
55+
.uri(URI.create(ReSMSConfig.BASE_URL + SEND_SMS_PATH))
5656
.header("Content-Type", "application/json")
5757
.header("X-Api-Key", config.getApiKey())
5858
.timeout(Duration.ofSeconds(config.getTimeoutSeconds()))

src/main/java/dev/resms/service/SmsService.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
import dev.resms.model.request.SendSmsRequest;
66
import dev.resms.model.response.SendSmsResponse;
77
import dev.resms.repository.SmsRepository;
8-
import dev.resms.util.ValidationUtil;
8+
import dev.resms.utils.ValidationUtil;
99

1010
/**
1111
* SMS service for sending SMS messages

src/main/java/dev/resms/util/ValidationUtil.java renamed to src/main/java/dev/resms/utils/ValidationUtil.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package dev.resms.util;
1+
package dev.resms.utils;
22

33
import dev.resms.exception.ReSMSException;
44
import dev.resms.model.request.SendSmsRequest;

src/test/java/dev/resms/util/ValidationUtilTest.java renamed to src/test/java/dev/resms/utils/ValidationUtilTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
package dev.resms.util;
1+
package dev.resms.utils;
22

33
import dev.resms.exception.ReSMSException;
44
import org.junit.jupiter.api.Test;

0 commit comments

Comments
 (0)