Skip to content

Commit 5ca0123

Browse files
committed
Make checklist responder case insensitive for the GH handle
1 parent 4104ed1 commit 5ca0123

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

app/responders/reviewer_checklist_comment_responder.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ def process_message(message)
2222
end
2323

2424
def sender_in_reviewers_list?
25-
reviewers.include?("@#{context.sender}")
25+
reviewers.include?("@#{context.sender.downcase}")
2626
end
2727

2828
def update_checklists_links
@@ -38,7 +38,7 @@ def update_checklists_links
3838
end
3939

4040
def reviewers
41-
@reviewers ||= read_value_from_body("reviewers-list").split(",").map(&:strip)
41+
@reviewers ||= read_value_from_body("reviewers-list").split(",").map(&:strip).map(&:downcase)
4242
end
4343

4444
def checklists_mapping

spec/responders/reviewer_checklist_comment_responder_spec.rb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,18 @@
5151
@responder.process_message(@msg)
5252
end
5353

54+
it "should be case insensitive for the reviewer's username" do
55+
@responder.context[:sender] = "ReVIEwer1"
56+
57+
expected_locals = { issue_id: 5, issue_author: "opener", bot_name: "botsci", repo: "openjournals/buffy", sender: "ReVIEwer1" }
58+
expected_checklist = "Checklist for @reviewer1 \n[] A"
59+
60+
expect(@responder).to receive(:render_external_template).with("checklist.md", expected_locals).and_return(expected_checklist)
61+
expect(@responder).to receive(:update_comment).with(111222, expected_checklist)
62+
expect(@responder).to_not receive(:respond)
63+
@responder.process_message(@msg)
64+
end
65+
5466
it "should not add user checklist if sender is not a reviewer" do
5567
@responder.context[:sender] = "nonreviewer"
5668

0 commit comments

Comments
 (0)