Make reminders responder case insensitive

Author: xuanxu

app/responders/reminders_responder.rb

@@ -17,19 +17,20 @@ def process_message(message)
 
     human = "@#{user_login(context.sender)}" if human == "me"
 
-    unless targets.include?(human)
+    unless targets.include?(human.downcase)
       respond("#{human} doesn't seem to be a reviewer or author for this submission.")
       return false
     end
 
     schedule_at = target_time(size, unit)
 
     if schedule_at
-      if user_login(human) == user_login(context.sender)
+      if user_login(human).downcase == user_login(context.sender).downcase
+        human = "@#{user_login(context.sender)}"
         msg = ":wave: #{human}, please take a look at the state of the submission (this is an automated reminder)."
         AsyncMessageWorker.perform_at(schedule_at, serializable(locals), msg)
       else
-        ReviewReminderWorker.perform_at(schedule_at, serializable(locals), human, authors_list.include?(human))
+        ReviewReminderWorker.perform_at(schedule_at, serializable(locals), human, authors_list.include?(human.downcase))
       end
       respond("Reminder set for #{human} in #{size} #{unit}")
     else
@@ -38,16 +39,16 @@ def process_message(message)
   end
 
   def targets
-    (authors_list + reviewers_list + ["@#{user_login(context.sender)}"]).uniq
+    (authors_list + reviewers_list + ["@#{user_login(context.sender).downcase}"]).uniq
   end
 
   def reviewers_list
-    @reviewers_list ||= reviewers_value.inject([]) {|re, value| re + read_value_from_body(value).split(",").map(&:strip)}
+    @reviewers_list ||= reviewers_value.inject([]) {|re, value| re + read_value_from_body(value).split(",").map(&:strip).map(&:downcase)}
     @reviewers_list.compact.uniq
   end
 
   def authors_list
-    @authors_list ||= authors_value.inject([]) {|au, value| au + read_value_from_body(value).split(",").map(&:strip)}
+    @authors_list ||= authors_value.inject([]) {|au, value| au + read_value_from_body(value).split(",").map(&:strip).map(&:downcase)}
     @authors_list.compact.uniq
   end
 

spec/responders/reminders_responder_spec.rb

@@ -56,6 +56,19 @@
       @responder.process_message(msg)
     end
 
+    it "should be case insensitive with the editor's GitHub handles" do
+      msg = "@botsci remind @eDItoR21 in 5 weeks"
+      @responder.match_data = @responder.event_regex.match(msg)
+      in_five_weeks = Chronic.parse("in 5 weeks")
+      expect(@responder).to receive(:target_time).with("5", "weeks").and_return(in_five_weeks)
+      expected_msg = ":wave: @editor21, please take a look at the state of the submission (this is an automated reminder)."
+      expect(AsyncMessageWorker).to receive(:perform_at).with(in_five_weeks, @responder.locals, expected_msg)
+      expect(ReviewReminderWorker).to_not receive(:perform_at)
+      expect(@responder).to receive(:respond).with("Reminder set for @editor21 in 5 weeks")
+
+      @responder.process_message(msg)
+    end
+
     it "should respond success message and schedule worker run for 'me'" do
       msg = "@botsci remind me in 15 days"
       @responder.match_data = @responder.event_regex.match(msg)
@@ -88,6 +101,26 @@
       expect(ReviewReminderWorker).to receive(:perform_at).with(in_four_days, @responder.locals, "@author", true)
       @responder.process_message(msg)
     end
+
+    it "should be case insensitive with the reviewers GitHub handles" do
+      msg = "@botsci remind @ReVieWEr42 in 3 weeks"
+      @responder.match_data = @responder.event_regex.match(msg)
+      expect(ReviewReminderWorker).to receive(:perform_at)
+      expect(@responder).to receive(:respond).with("Reminder set for @ReVieWEr42 in 3 weeks")
+
+      @responder.process_message(msg)
+    end
+
+    it "should be case insensitive with the authors GitHub handles" do
+      msg = "@botsci remind @AUTHor in 4 days"
+      @responder.match_data = @responder.event_regex.match(msg)
+
+      in_four_days = Chronic.parse("in 4 days")
+      expect(@responder).to receive(:target_time).with("4", "days").and_return(in_four_days)
+
+      expect(ReviewReminderWorker).to receive(:perform_at).with(in_four_days, @responder.locals, "@AUTHor", true)
+      @responder.process_message(msg)
+    end
   end
 
   describe "configurable targets" do