Skip to content

Commit a69b563

Browse files
committed
Make responder resilient to multiple spaces around username
1 parent 6a4f579 commit a69b563

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

app/responders/openjournals/reviewers_list_with_external_call_responder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ class ReviewersListWithExternalCallResponder < Responder
88

99
def define_listening
1010
@event_action = "issue_comment.created"
11-
@event_regex = /\A@#{bot_name} (add|remove) (\S+) (to reviewers|from reviewers|as reviewer)\.?\s*$/i
11+
@event_regex = /\A@#{bot_name} (add|remove) +(\S+) +(to reviewers|from reviewers|as reviewer)\.?\s*$/i
1212
end
1313

1414
def process_message(message)

spec/responders/openjournals/reviewers_list_with_external_call_responder_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,13 +16,18 @@
1616

1717
it "should define regex" do
1818
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
19+
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
20+
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
21+
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
1922
expect(@responder.event_regex).to match("@botsci add @arfon as reviewer")
2023
expect(@responder.event_regex).to match("@botsci add me as reviewer")
2124
expect(@responder.event_regex).to match("@botsci remove me from reviewers")
2225
expect(@responder.event_regex).to match("@botsci remove @arfon from reviewers ")
2326
expect(@responder.event_regex).to match("@botsci remove @arfon from reviewers \r\n")
2427
expect(@responder.event_regex).to match("@botsci remove @arfon from reviewers \r\n more ")
2528
expect(@responder.event_regex).to_not match("@botsci add to reviewers")
29+
expect(@responder.event_regex).to_not match("@botsci add@arfon to reviewers")
30+
expect(@responder.event_regex).to_not match("@botsci add @arfonto reviewers")
2631
expect(@responder.event_regex).to_not match("@botsci remove from reviewers")
2732
end
2833
end

0 commit comments

Comments
 (0)