Skip to content

Commit ca73b60

Browse files
committed
Make responder resilient to multiple spaces around username
1 parent 099ce47 commit ca73b60

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

app/responders/reviewers_list_responder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ class ReviewersListResponder < Responder
66

77
def define_listening
88
@event_action = "issue_comment.created"
9-
@event_regex = /\A@#{bot_name} (add|remove) (\S+) (to reviewers|from reviewers|as reviewer)\.?\s*$/i
9+
@event_regex = /\A@#{bot_name} (add|remove) +(\S+) +(to reviewers|from reviewers|as reviewer)\.?\s*$/i
1010
end
1111

1212
def process_message(message)

spec/responders/reviewers_list_responder_spec.rb

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,18 @@
1515

1616
it "should define regex" do
1717
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
18+
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
19+
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
20+
expect(@responder.event_regex).to match("@botsci add @arfon to reviewers")
1821
expect(@responder.event_regex).to match("@botsci add @arfon as reviewer")
1922
expect(@responder.event_regex).to match("@botsci add me as reviewer")
2023
expect(@responder.event_regex).to match("@botsci remove me from reviewers")
2124
expect(@responder.event_regex).to match("@botsci remove @arfon from reviewers ")
2225
expect(@responder.event_regex).to match("@botsci remove @arfon from reviewers \r\n")
2326
expect(@responder.event_regex).to match("@botsci remove @arfon from reviewers \r\n more ")
2427
expect(@responder.event_regex).to_not match("@botsci add to reviewers")
28+
expect(@responder.event_regex).to_not match("@botsci add@arfon to reviewers")
29+
expect(@responder.event_regex).to_not match("@botsci add @arfonto reviewers")
2530
expect(@responder.event_regex).to_not match("@botsci remove from reviewers")
2631
end
2732
end

0 commit comments

Comments
 (0)