Skip to content

Commit 57ed494

Browse files
committed
Remove explicit bash call and use new env name standard
1 parent ca04fc8 commit 57ed494

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

.github/workflows/build_pull_request.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ jobs:
3737

3838
- name: Compile aapt2
3939
env:
40-
ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
40+
ANDROID_NDK: ${{ steps.setup-ndk.outputs.ndk-path }}
4141
run: bash ./build.sh ${{ matrix.target_arch }}
4242

4343
- name: Upload artifacts

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ jobs:
3838

3939
- name: Build
4040
env:
41-
ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
41+
ANDROID_NDK: ${{ steps.setup-ndk.outputs.ndk-path }}
4242
run: bash ./build.sh ${{ matrix.target_arch }}
4343

4444
- name: Upload artifacts

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,14 @@ grep PROTOC_VERSION src/protobuf/protobuf_version.bzl
2929

3030
## Apply patch
3131
```bash
32-
bash ./patch.sh
32+
./patch.sh
3333
```
3434

3535
## Build the binary
3636

3737
Supported arch are 'x86_64', 'x86', 'arm64-v8a' & 'armeabi-v7a'
3838
```bash
39-
ANDROID_NDK="$HOME/Android/Sdk/ndk/" bash ./build.sh arm64-v8a # Build output in build/bin/aapt-*
39+
ANDROID_NDK="$HOME/Android/Sdk/ndk/" ./build.sh arm64-v8a # Build output in build/bin/aapt-*
4040
```
4141

4242
# Credits

0 commit comments

Comments
 (0)