Skip to content

Commit 8210983

Browse files
committed
refactor: Merge AppSelector and InstalledApp screens viewmodels
1 parent c2e434c commit 8210983

File tree

9 files changed

+156
-512
lines changed

9 files changed

+156
-512
lines changed

app/src/main/java/app/revanced/manager/MainActivity.kt

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import androidx.navigation.toRoute
3030
import app.revanced.manager.domain.repository.ChangelogSource
3131
import app.revanced.manager.ui.model.navigation.Announcement
3232
import app.revanced.manager.ui.model.navigation.Announcements
33-
import app.revanced.manager.ui.model.navigation.AppSelector
3433
import app.revanced.manager.ui.model.navigation.BundleInformation
3534
import app.revanced.manager.ui.model.navigation.ComplexParameter
3635
import app.revanced.manager.ui.model.navigation.Dashboard
@@ -42,7 +41,6 @@ import app.revanced.manager.ui.model.navigation.Settings
4241
import app.revanced.manager.ui.model.navigation.Update
4342
import app.revanced.manager.ui.screen.AnnouncementScreen
4443
import app.revanced.manager.ui.screen.AnnouncementsScreen
45-
import app.revanced.manager.ui.screen.AppSelectorScreen
4644
import app.revanced.manager.ui.screen.BundleInformationScreen
4745
import app.revanced.manager.ui.screen.DashboardScreen
4846
import app.revanced.manager.ui.screen.InstalledAppInfoScreen
@@ -166,9 +164,6 @@ private fun ReVancedManager(vm: MainViewModel) {
166164
composable<Dashboard> {
167165
DashboardScreen(
168166
onSettingsClick = { navController.navigateSafe(Settings) },
169-
onAppSelectorClick = {
170-
navController.navigateSafe(AppSelector)
171-
},
172167
onUpdateClick = {
173168
navController.navigateSafe(Update())
174169
},
@@ -215,14 +210,6 @@ private fun ReVancedManager(vm: MainViewModel) {
215210
)
216211
}
217212

218-
composable<AppSelector> {
219-
AppSelectorScreen(
220-
onSelect = vm::selectApp,
221-
onStorageSelect = vm::selectApp,
222-
onBackClick = navController::popBackStackSafe
223-
)
224-
}
225-
226213
composable<Patcher> {
227214
PatcherScreen(
228215
onBackClick = {

app/src/main/java/app/revanced/manager/di/ViewModelModule.kt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ val viewModelModule = module {
1212
viewModelOf(::PatchesSelectorViewModel)
1313
viewModelOf(::GeneralSettingsViewModel)
1414
viewModelOf(::AdvancedSettingsViewModel)
15-
viewModelOf(::AppSelectorViewModel)
1615
viewModelOf(::PatcherViewModel)
1716
viewModelOf(::UpdateViewModel)
1817
viewModelOf(::AnnouncementsViewModel)
@@ -22,7 +21,7 @@ val viewModelModule = module {
2221
viewModelOf(::DeveloperOptionsViewModel)
2322
viewModelOf(::ContributorViewModel)
2423
viewModelOf(::DownloadsViewModel)
25-
viewModelOf(::InstalledAppsViewModel)
24+
viewModelOf(::AppsViewModel)
2625
viewModelOf(::InstalledAppInfoViewModel)
2726
viewModelOf(::UpdatesSettingsViewModel)
2827
viewModelOf(::BundleListViewModel)

app/src/main/java/app/revanced/manager/ui/model/navigation/Nav.kt

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,6 @@ object Onboarding
1818
@Serializable
1919
object Dashboard
2020

21-
@Serializable
22-
object AppSelector
23-
2421
@Serializable
2522
data class InstalledApplicationInfo(val packageName: String)
2623

app/src/main/java/app/revanced/manager/ui/screen/AppSelectorScreen.kt

Lines changed: 0 additions & 262 deletions
This file was deleted.

0 commit comments

Comments
 (0)