Skip to content

Commit 4b2829b

Browse files
refactor
1 parent 960506e commit 4b2829b

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

extensions/music/src/main/java/app/revanced/extension/music/settings/preference/MusicPreferenceFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ protected void initialize() {
3838
// a root install. So instead the non-functional preferences are removed during runtime
3939
// if the app is mount (root) installation.
4040
if (GmsCoreSupport.isPackageNameOriginal()) {
41-
removePreferencesIfRooted(
41+
removePreferences(
4242
"revanced_custom_branding_name",
4343
"revanced_custom_branding_icon");
4444
}

extensions/shared/library/src/main/java/app/revanced/extension/shared/settings/preference/ToolbarPreferenceFragment.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,13 @@ public class ToolbarPreferenceFragment extends AbstractPreferenceFragment {
2828
* Removes the list of preferences from this fragment, if they exist.
2929
* @param keys Preference keys.
3030
*/
31-
protected void removePreferencesIfRooted(String ... keys) {
31+
protected void removePreferences(String ... keys) {
3232
for (String key : keys) {
3333
Preference pref = findPreference(key);
3434
if (pref != null) {
35-
Logger.printDebug(() -> "Removing root incompatible preference: " + key);
36-
// remove the preference
3735
PreferenceGroup parent = pref.getParent();
3836
if (parent != null) {
37+
Logger.printDebug(() -> "Removing preference: " + key);
3938
parent.removePreference(pref);
4039
}
4140
}

extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/preference/YouTubePreferenceFragment.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ protected void initialize() {
3838
// a root install. So instead the non-functional preferences are removed during runtime
3939
// if the app is mount (root) installation.
4040
if (GmsCoreSupport.isPackageNameOriginal()) {
41-
removePreferencesIfRooted(
41+
removePreferences(
4242
"revanced_custom_branding_name",
4343
"revanced_custom_branding_icon");
4444
}

0 commit comments

Comments
 (0)