fix(Pandora - Disable ads): Support latest app target (#5185)

Author: hoo-dles

patches/src/main/kotlin/app/revanced/patches/pandora/ads/DisableAudioAdsPatch.kt

@@ -1,12 +1,7 @@
 package app.revanced.patches.pandora.ads
 
-import app.revanced.patcher.extensions.InstructionExtensions.addInstruction
-import app.revanced.patcher.extensions.InstructionExtensions.getInstruction
 import app.revanced.patcher.patch.bytecodePatch
-import app.revanced.patches.pandora.shared.constructUserDataFingerprint
-import app.revanced.util.indexOfFirstInstructionOrThrow
-import com.android.tools.smali.dexlib2.Opcode
-import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction
+import app.revanced.util.returnEarly
 
 @Suppress("unused")
 val disableAudioAdsPatch = bytecodePatch(
@@ -15,16 +10,7 @@ val disableAudioAdsPatch = bytecodePatch(
     compatibleWith("com.pandora.android")
 
     execute {
-        constructUserDataFingerprint.method.apply {
-            // First match is "hasAudioAds".
-            val hasAudioAdsStringIndex = constructUserDataFingerprint.stringMatches!!.first().index
-            val moveResultIndex = indexOfFirstInstructionOrThrow(hasAudioAdsStringIndex, Opcode.MOVE_RESULT)
-            val hasAudioAdsRegister = getInstruction<OneRegisterInstruction>(moveResultIndex).registerA
-
-            addInstruction(
-                moveResultIndex + 1,
-                "const/4 v$hasAudioAdsRegister, 0"
-            )
-        }
+        getIsAdSupportedFingerprint.method.returnEarly(false)
+        requestAudioAdFingerprint.method.returnEarly()
     }
 }

patches/src/main/kotlin/app/revanced/patches/pandora/ads/Fingerprints.kt

@@ -0,0 +1,15 @@
+package app.revanced.patches.pandora.ads
+
+import app.revanced.patcher.fingerprint
+
+internal val getIsAdSupportedFingerprint = fingerprint {
+    custom { method, classDef ->
+        method.name == "getIsAdSupported" && classDef.endsWith("UserData;")
+    }
+}
+
+internal val requestAudioAdFingerprint = fingerprint {
+    custom { method, classDef ->
+        method.name == "requestAudioAdFromAdSDK" && classDef.endsWith("ContentServiceOpsImpl;")
+    }
+}

patches/src/main/kotlin/app/revanced/patches/pandora/misc/EnableUnlimitedSkipsPatch.kt

@@ -1,12 +1,7 @@
 package app.revanced.patches.pandora.misc
 
-import app.revanced.patcher.extensions.InstructionExtensions.addInstruction
-import app.revanced.patcher.extensions.InstructionExtensions.getInstruction
 import app.revanced.patcher.patch.bytecodePatch
-import app.revanced.patches.pandora.shared.constructUserDataFingerprint
-import app.revanced.util.indexOfFirstInstructionOrThrow
-import com.android.tools.smali.dexlib2.Opcode
-import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction
+import app.revanced.util.returnEarly
 
 @Suppress("unused")
 val enableUnlimitedSkipsPatch = bytecodePatch(
@@ -15,17 +10,6 @@ val enableUnlimitedSkipsPatch = bytecodePatch(
     compatibleWith("com.pandora.android")
 
     execute {
-        constructUserDataFingerprint.method.apply {
-            // Last match is "skipLimitBehavior".
-            val skipLimitBehaviorStringIndex = constructUserDataFingerprint.stringMatches!!.last().index
-            val moveResultObjectIndex =
-                indexOfFirstInstructionOrThrow(skipLimitBehaviorStringIndex, Opcode.MOVE_RESULT_OBJECT)
-            val skipLimitBehaviorRegister = getInstruction<OneRegisterInstruction>(moveResultObjectIndex).registerA
-
-            addInstruction(
-                moveResultObjectIndex + 1,
-                "const-string v$skipLimitBehaviorRegister, \"unlimited\""
-            )
-        }
+        skipLimitBehaviorFingerprint.method.returnEarly("unlimited")
     }
 }

patches/src/main/kotlin/app/revanced/patches/pandora/misc/Fingerprints.kt

@@ -0,0 +1,9 @@
+package app.revanced.patches.pandora.misc
+
+import app.revanced.patcher.fingerprint
+
+internal val skipLimitBehaviorFingerprint = fingerprint {
+    custom { method, classDef ->
+        method.name == "getSkipLimitBehavior" && classDef.endsWith("UserData;")
+    }
+}