refactor

Author: LisoUseInAIKyrios

extensions/music/src/main/java/app/revanced/extension/music/settings/preference/MusicPreferenceFragment.java

@@ -8,6 +8,7 @@
 import app.revanced.extension.shared.GmsCoreSupport;
 import app.revanced.extension.shared.Logger;
 import app.revanced.extension.shared.Utils;
+import app.revanced.extension.shared.settings.BaseSettings;
 import app.revanced.extension.shared.settings.preference.ToolbarPreferenceFragment;
 
 /**
@@ -35,12 +36,12 @@ protected void initialize() {
             // Clunky work around until preferences are custom classes that manage themselves.
             // Custom branding only works with non-root install. But the preferences must be
             // added during patched because of difficulties detecting during patching if it's
-            // a root install. So instead the non-functional preferences are removed during runtime
-            // if the app is mount (root) installation.
+            // a root install. So instead the non-functional preferences are removed during
+            // runtime if the app is mount (root) installation.
             if (GmsCoreSupport.isPackageNameOriginal()) {
                 removePreferences(
-                        "revanced_custom_branding_name",
-                        "revanced_custom_branding_icon");
+                        BaseSettings.CUSTOM_BRANDING_ICON.key,
+                        BaseSettings.CUSTOM_BRANDING_NAME.key);
             }
         } catch (Exception ex) {
             Logger.printException(() -> "initialize failure", ex);

extensions/shared/library/src/main/java/app/revanced/extension/shared/patches/CustomBrandingPatch.java

@@ -78,7 +78,7 @@ public static void setNotificationIcon(Notification.Builder builder) {
         try {
             if (notificationSmallIcon != 0) {
                 builder.setSmallIcon(notificationSmallIcon)
-                        .setColor(0x00000000); // Remove YT red tint.
+                        .setColor(Color.TRANSPARENT); // Remove YT red tint.
             }
         } catch (Exception ex) {
             Logger.printException(() -> "setNotificationIcon failure", ex);

extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/preference/YouTubePreferenceFragment.java

@@ -7,6 +7,7 @@
 import app.revanced.extension.shared.GmsCoreSupport;
 import app.revanced.extension.shared.Logger;
 import app.revanced.extension.shared.Utils;
+import app.revanced.extension.shared.settings.BaseSettings;
 import app.revanced.extension.shared.settings.preference.ToolbarPreferenceFragment;
 import app.revanced.extension.youtube.settings.YouTubeActivityHook;
 
@@ -35,12 +36,12 @@ protected void initialize() {
             // Clunky work around until preferences are custom classes that manage themselves.
             // Custom branding only works with non-root install. But the preferences must be
             // added during patched because of difficulties detecting during patching if it's
-            // a root install. So instead the non-functional preferences are removed during runtime
-            // if the app is mount (root) installation.
+            // a root install. So instead the non-functional preferences are removed during
+            // runtime if the app is mount (root) installation.
             if (GmsCoreSupport.isPackageNameOriginal()) {
                 removePreferences(
-                        "revanced_custom_branding_name",
-                        "revanced_custom_branding_icon");
+                        BaseSettings.CUSTOM_BRANDING_ICON.key,
+                        BaseSettings.CUSTOM_BRANDING_NAME.key);
             }
         } catch (Exception ex) {
             Logger.printException(() -> "initialize failure", ex);