Skip to content

Commit b6caa04

Browse files
committed
fix: container not ready
1 parent 1e649f8 commit b6caa04

18 files changed

+96
-9
lines changed

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/glassfish/GlassFish3ContainerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ public class GlassFish3ContainerTest {
5454

5555
@BeforeAll
5656
static void setup() {
57-
container.waitingFor(Wait.forHttp("/app/"));
57+
container.waitingFor(Wait.forLogMessage(".*(deployed|done).*", 1));
5858
}
5959

6060
static Stream<Arguments> casesProvider() {

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/glassfish/GlassFish4ContainerTest.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
import org.testcontainers.junit.jupiter.Container;
2121
import org.testcontainers.junit.jupiter.Testcontainers;
2222

23-
import java.time.Duration;
2423
import java.util.List;
2524
import java.util.stream.Stream;
2625

@@ -54,7 +53,7 @@ public class GlassFish4ContainerTest {
5453

5554
@BeforeAll
5655
static void setup() {
57-
container.waitingFor(Wait.forHttp("/app/"));
56+
container.waitingFor(Wait.forLogMessage(".*(deployed|done).*", 1));
5857
}
5958

6059
static Stream<Arguments> casesProvider() {

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/glassfish/GlassFish501ContainerTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import lombok.extern.slf4j.Slf4j;
99
import net.bytebuddy.jar.asm.Opcodes;
1010
import org.junit.jupiter.api.AfterAll;
11+
import org.junit.jupiter.api.BeforeAll;
1112
import org.junit.jupiter.params.ParameterizedTest;
1213
import org.junit.jupiter.params.provider.Arguments;
1314
import org.junit.jupiter.params.provider.MethodSource;
@@ -63,6 +64,11 @@ static Stream<Arguments> casesProvider() {
6364
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers);
6465
}
6566

67+
@BeforeAll
68+
static void setup() {
69+
container.waitingFor(Wait.forLogMessage(".*(deployed|done).*", 1));
70+
}
71+
6672
@AfterAll
6773
static void tearDown() {
6874
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/glassfish/GlassFish510ContainerTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import lombok.extern.slf4j.Slf4j;
99
import net.bytebuddy.jar.asm.Opcodes;
1010
import org.junit.jupiter.api.AfterAll;
11+
import org.junit.jupiter.api.BeforeAll;
1112
import org.junit.jupiter.params.ParameterizedTest;
1213
import org.junit.jupiter.params.provider.Arguments;
1314
import org.junit.jupiter.params.provider.MethodSource;
@@ -63,6 +64,11 @@ static Stream<Arguments> casesProvider() {
6364
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers);
6465
}
6566

67+
@BeforeAll
68+
static void setup() {
69+
container.waitingFor(Wait.forLogMessage(".*(deployed|done).*", 1));
70+
}
71+
6672
@AfterAll
6773
static void tearDown() {
6874
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/glassfish/GlassFish6ContainerTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import lombok.extern.slf4j.Slf4j;
1010
import net.bytebuddy.jar.asm.Opcodes;
1111
import org.junit.jupiter.api.AfterAll;
12+
import org.junit.jupiter.api.BeforeAll;
1213
import org.junit.jupiter.params.ParameterizedTest;
1314
import org.junit.jupiter.params.provider.Arguments;
1415
import org.junit.jupiter.params.provider.MethodSource;
@@ -62,6 +63,11 @@ static Stream<Arguments> casesProvider() {
6263
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers, null, List.of(ShellTool.AntSword));
6364
}
6465

66+
@BeforeAll
67+
static void setup() {
68+
container.waitingFor(Wait.forLogMessage(".*(deployed|done).*", 1));
69+
}
70+
6571
@AfterAll
6672
static void tearDown() {
6773
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/glassfish/GlassFish7ContainerTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import lombok.extern.slf4j.Slf4j;
1010
import net.bytebuddy.jar.asm.Opcodes;
1111
import org.junit.jupiter.api.AfterAll;
12+
import org.junit.jupiter.api.BeforeAll;
1213
import org.junit.jupiter.params.ParameterizedTest;
1314
import org.junit.jupiter.params.provider.Arguments;
1415
import org.junit.jupiter.params.provider.MethodSource;
@@ -48,7 +49,7 @@ public class GlassFish7ContainerTest {
4849
.withCopyToContainer(glassfishPid, "/fetch_pid.sh")
4950
.withNetwork(network)
5051
.withNetworkAliases("app")
51-
.waitingFor(Wait.forHttp("/app"))
52+
.waitingFor(Wait.forLogMessage(".*JMXService.*", 1))
5253
.withExposedPorts(8080);
5354

5455
static Stream<Arguments> casesProvider() {
@@ -64,6 +65,11 @@ static Stream<Arguments> casesProvider() {
6465
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers, null, List.of(ShellTool.AntSword));
6566
}
6667

68+
@BeforeAll
69+
static void setup() {
70+
container.waitingFor(Wait.forHttp("/app/test"));
71+
}
72+
6773
@AfterAll
6874
static void tearDown() {
6975
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/payara/Payara5201ContainerTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import lombok.extern.slf4j.Slf4j;
99
import net.bytebuddy.jar.asm.Opcodes;
1010
import org.junit.jupiter.api.AfterAll;
11+
import org.junit.jupiter.api.BeforeAll;
1112
import org.junit.jupiter.params.ParameterizedTest;
1213
import org.junit.jupiter.params.provider.Arguments;
1314
import org.junit.jupiter.params.provider.MethodSource;
@@ -63,6 +64,11 @@ static Stream<Arguments> casesProvider() {
6364
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers);
6465
}
6566

67+
@BeforeAll
68+
static void setup() {
69+
container.waitingFor(Wait.forLogMessage(".*JMXService.*", 1));
70+
}
71+
6672
@AfterAll
6773
static void tearDown() {
6874
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/payara/Payara520225ContainerTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import lombok.extern.slf4j.Slf4j;
99
import net.bytebuddy.jar.asm.Opcodes;
1010
import org.junit.jupiter.api.AfterAll;
11+
import org.junit.jupiter.api.BeforeAll;
1112
import org.junit.jupiter.params.ParameterizedTest;
1213
import org.junit.jupiter.params.provider.Arguments;
1314
import org.junit.jupiter.params.provider.MethodSource;
@@ -63,6 +64,11 @@ static Stream<Arguments> casesProvider() {
6364
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers);
6465
}
6566

67+
@BeforeAll
68+
static void setup() {
69+
container.waitingFor(Wait.forLogMessage(".*JMXService.*", 1));
70+
}
71+
6672
@AfterAll
6773
static void tearDown() {
6874
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/memshell/payara/Payara620222ContainerTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@
99
import lombok.extern.slf4j.Slf4j;
1010
import net.bytebuddy.jar.asm.Opcodes;
1111
import org.junit.jupiter.api.AfterAll;
12+
import org.junit.jupiter.api.BeforeAll;
1213
import org.junit.jupiter.params.ParameterizedTest;
1314
import org.junit.jupiter.params.provider.Arguments;
1415
import org.junit.jupiter.params.provider.MethodSource;
@@ -46,7 +47,7 @@ public class Payara620222ContainerTest {
4647
.withCopyToContainer(glassfishPid, "/fetch_pid.sh")
4748
.withNetwork(network)
4849
.withNetworkAliases("app")
49-
.waitingFor(Wait.forHttp("/app"))
50+
.waitingFor(Wait.forLogMessage(".*JMXService.*", 1))
5051
.withExposedPorts(8080);
5152

5253
static Stream<Arguments> casesProvider() {
@@ -62,6 +63,11 @@ static Stream<Arguments> casesProvider() {
6263
return TestCasesProvider.getTestCases(imageName, server, supportedShellTypes, testPackers, null, List.of(ShellTool.AntSword));
6364
}
6465

66+
@BeforeAll
67+
static void setup() {
68+
container.waitingFor(Wait.forHttp("/app/test"));
69+
}
70+
6571
@AfterAll
6672
static void tearDown() {
6773
String logs = container.getLogs();

integration-test/src/test/java/com/reajason/javaweb/integration/probe/glassfish/GlassFish3ContainerTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,10 @@ public class GlassFish3ContainerTest {
3636
.withCopyToContainer(warFile, "/usr/local/glassfish3/glassfish/domains/domain1/autodeploy/app.war")
3737
.waitingFor(Wait.forHttp("/app"))
3838
.withExposedPorts(8080);
39+
3940
@BeforeAll
4041
static void setup() {
41-
container.waitingFor(Wait.forHttp("/app/"));
42+
container.waitingFor(Wait.forLogMessage(".*(deployed|done).*", 1));
4243
}
4344

4445
@Test

0 commit comments

Comments
 (0)