[Test] Fix AlamofireTests where task captures downloadRequest via configure.

inamiy · inamiy · commit 61d2db789a79 · 2014-09-23T23:28:50.000+09:00
diff --git a/SwiftTaskTests/AlamofireTests.swift b/SwiftTaskTests/AlamofireTests.swift
@@ -219,9 +219,11 @@ class AlamofireTests: _TestCase
             }
             
             // configure cancel for cleanup after reject or task.cancel()
-            configure.cancel = {
-                downloadRequst.cancel()
-                return
+            // NOTE: use weak to let task NOT CAPTURE downloadRequst via configure
+            configure.cancel = { [weak downloadRequst] in
+                if let downloadRequst = downloadRequst {
+                    downloadRequst.cancel()
+                }
             }
             
         } // end of 1st task definition (NOTE: don't chain with `then` or `catch` for 1st task cancellation)

Original file line number	Diff line number	Diff line change
`@@ -219,9 +219,11 @@ class AlamofireTests: _TestCase`
`219`	`219`	`}`
`220`	`220`
`221`	`221`	`// configure cancel for cleanup after reject or task.cancel()`
`222`		`- configure.cancel = {`
`223`		`- downloadRequst.cancel()`
`224`		`- return`
	`222`	`+ // NOTE: use weak to let task NOT CAPTURE downloadRequst via configure`
	`223`	`+ configure.cancel = { [weak downloadRequst] in`
	`224`	`+ if let downloadRequst = downloadRequst {`
	`225`	`+ downloadRequst.cancel()`
	`226`	`+ }`
`225`	`227`	`}`
`226`	`228`
`227`	`229`	} // end of 1st task definition (NOTE: don't chain with `then` or `catch` for 1st task cancellation)