Skip to content

Commit 49dcb57

Browse files
hannesa2hannesa2
committed
api34
1 parent f360443 commit 49dcb57

File tree

15 files changed

+34
-28
lines changed

15 files changed

+34
-28
lines changed

‎.github/workflows/pull-request.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,12 @@ jobs:
2121
- name: assemble ViroCore
2222
run: |
2323
./gradlew :viroreact:assembleDebug
24+
./gradlew :code-samples:ARPlacingObjects:assembleDebug
25+
./gradlew :code-samples:ARRetail:assembleDebug
26+
./gradlew :code-samples:ARTesla:assembleDebug
27+
./gradlew :code-samples:ARHelloWorldAndroid:assembleDebug
28+
./gradlew :code-samples:ARBlackPanther:assembleDebug
29+
./gradlew :mainSample:assembleDebug
2430
working-directory: ./android
2531
- name: Upload result ViroCore
2632
uses: actions/[email protected]

‎android/code-samples/ARBlackPanther/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
apply plugin: 'com.android.library'
22

33
android {
4-
compileSdkVersion 33
4+
compileSdkVersion 34
55
namespace "com.example.virosample.blackPanther"
66

77
defaultConfig {
88
minSdkVersion 24
9-
targetSdkVersion 33
9+
targetSdkVersion 34
1010
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
1111
ndkVersion = "25.2.9519653"
1212
ndk {

‎android/code-samples/ARHelloWorldAndroid/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
apply plugin: 'com.android.library'
22

33
android {
4-
compileSdkVersion 33
4+
compileSdkVersion 34
55
namespace "com.example.virosample.hello"
66

77
defaultConfig {
88
minSdkVersion 24
9-
targetSdkVersion 33
9+
targetSdkVersion 34
1010
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
1111
ndkVersion = "25.2.9519653"
1212
ndk {

‎android/code-samples/ARPlacingObjects/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@ apply plugin: 'com.android.library'
22
apply plugin: 'kotlin-android'
33

44
android {
5-
compileSdkVersion 33
5+
compileSdkVersion 34
66
namespace "com.example.virosample.placingObjects"
77

88
defaultConfig {
99
minSdkVersion 24
10-
targetSdkVersion 33
10+
targetSdkVersion 34
1111
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
1212
ndkVersion = "25.2.9519653"
1313
ndk {

‎android/code-samples/ARRetail/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
apply plugin: 'com.android.library'
22

33
android {
4-
compileSdkVersion 33
4+
compileSdkVersion 34
55
namespace "com.example.virosample.retail"
66

77
defaultConfig {
88
minSdkVersion 24
9-
targetSdkVersion 33
9+
targetSdkVersion 34
1010
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
1111
ndkVersion = "25.2.9519653"
1212
ndk {

‎android/code-samples/ARTesla/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
apply plugin: 'com.android.library'
22

33
android {
4-
compileSdkVersion 33
4+
compileSdkVersion 34
55
namespace "com.example.virosample.tesla"
66

77
defaultConfig {
88
minSdkVersion 24
9-
targetSdkVersion 33
9+
targetSdkVersion 34
1010
testInstrumentationRunner 'androidx.test.runner.AndroidJUnitRunner'
1111
ndkVersion = "25.2.9519653"
1212
ndk {

‎android/mainSample/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ apply plugin: 'com.android.application'
22
apply plugin: 'kotlin-android'
33

44
android {
5-
compileSdkVersion 33
5+
compileSdkVersion 34
66
namespace "com.example.virosample"
77
buildFeatures {
88
buildConfig = true
@@ -11,7 +11,7 @@ android {
1111
defaultConfig {
1212
applicationId "com.example.virosample"
1313
minSdkVersion 24
14-
targetSdkVersion 33
14+
targetSdkVersion 34
1515

1616
// versionCode getGitCommitCount()
1717
// versionName getTag()

‎android/memoryleaktest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ android {
88
buildConfig = true
99
}
1010

11-
compileSdkVersion 33
11+
compileSdkVersion 34
1212
defaultConfig {
1313
applicationId "com.example.memoryleaktest"
1414
minSdkVersion 24
15-
targetSdkVersion 33
15+
targetSdkVersion 34
1616
versionCode 1
1717
versionName "1.0"
1818

‎android/nativetest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,12 +6,12 @@ android {
66
buildFeatures {
77
buildConfig = true
88
}
9-
compileSdkVersion 33
9+
compileSdkVersion 34
1010

1111
defaultConfig {
1212
applicationId "com.viro.nativetest"
1313
minSdkVersion 24
14-
targetSdkVersion 33
14+
targetSdkVersion 34
1515
versionCode 1
1616
versionName "1.0"
1717
missingDimensionStrategy 'product', 'viro_core'

‎android/releasetest/build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,15 +4,15 @@ apply plugin: 'kotlin-android'
44
android {
55
flavorDimensions "target_platform"
66
namespace "com.viromedia.releasetest"
7-
compileSdkVersion 33
7+
compileSdkVersion 34
88
buildFeatures {
99
buildConfig = true
1010
}
1111

1212
defaultConfig {
1313
applicationId "com.viromedia.releasetest"
1414
minSdkVersion 24
15-
targetSdkVersion 33
15+
targetSdkVersion 34
1616
versionCode 1
1717
versionName "1.0"
1818

0 commit comments

Comments
 (0)