Skip to content

Commit feb70e2

Browse files
committed
Raising NotImplementedError for some #TODO items, fixing units.
As discussed in #2321 (comment) But maybe we just merge #2597 and rebase this onto that.
1 parent 479abc2 commit feb70e2

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

rmgpy/kinetics/surface.pyx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -609,9 +609,11 @@ cdef class SurfaceArrhenius(Arrhenius):
609609
import cantera as ct
610610

611611
A = self._A.value_si
612+
raise NotImplementedError("The units need fixing from mol to kmol?")
613+
# SEE https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2597/
612614
b = self._n.value_si
613615
Ea = self._Ea.value_si * 1000 # convert from J/mol to J/kmol
614-
616+
raise NotImplementedError("Should return InterfaceArrheniusRate(A, b, E)? (and fix docstrings)")
615617
return ct.Arrhenius(A, b, Ea)
616618

617619

0 commit comments

Comments
 (0)