Skip to content
This repository was archived by the owner on Apr 20, 2018. It is now read-only.

Commit 800a1fa

Browse files
Updating some examples
1 parent 1b0e6bf commit 800a1fa

File tree

9 files changed

+102
-59
lines changed

9 files changed

+102
-59
lines changed

dist/rx.dom.compat.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -190,10 +190,11 @@
190190
events = events.split(' ');
191191

192192
for(var i = 0, len = events.length; i < len; i++) {
193-
var e = events[i];
194-
dom[e] = function (element, selector) {
195-
return fromEvent(element, e, selector);
196-
};
193+
(function (e) {
194+
dom[e] = function (element, selector) {
195+
return fromEvent(element, e, selector);
196+
};
197+
}(events[i]))
197198
}
198199
}());
199200

dist/rx.dom.compat.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rx.dom.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -122,10 +122,11 @@
122122
events = events.split(' ');
123123

124124
for(var i = 0, len = events.length; i < len; i++) {
125-
var e = events[i];
126-
dom[e] = function (element, selector) {
127-
return fromEvent(element, e, selector);
128-
};
125+
(function (e) {
126+
dom[e] = function (element, selector) {
127+
return fromEvent(element, e, selector);
128+
};
129+
}(events[i]))
129130
}
130131
}());
131132

dist/rx.dom.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

examples/Autocomplete/Autocomplete.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<![endif]-->
1515
</head>
1616

17-
<body onload="initialize();">
17+
<body>
1818
<div class="container">
1919
<div class="page-header">
2020
<h1>RxJS for jQuery Bindings AutoComplete example</h1>

examples/Autocomplete/autocomplete.js

Lines changed: 22 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -2,48 +2,49 @@
22

33
function searchWikipedia (term) {
44
var url = 'http://en.wikipedia.org/w/api.php?action=opensearch&format=json&search='
5-
+ term + '&callback=JSONPCallback';
6-
return Rx.DOM.Request.jsonpRequest(url);
5+
+ encodeURIComponent(term) + '&callback=JSONPCallback';
6+
return Rx.DOM.jsonpRequest(url);
77
}
88

99
function clearChildren (e) {
1010
while (e.firstChild) { e.removeChild(e.firstChild); }
1111
}
1212

13+
function createChildren(results, parent) {
14+
for (var i = 0, len = results.length; i < len; i++) {
15+
createElement(results[i], parent);
16+
}
17+
}
18+
19+
function createElement(text, parent) {
20+
var li = document.createElement('li');
21+
li.innerHTML = text;
22+
parent.appendChild(li);
23+
}
24+
1325
function initialize () {
1426
var input = document.getElementById('textInput'),
15-
ul = document.getElementById('results')
27+
ul = document.getElementById('results');
1628

17-
var keyup = Rx.Observable.fromEvent(input, 'keyup')
18-
.map(function(ev) {
19-
return ev.target.value;
20-
})
21-
.filter(function(text) {
22-
return text.length > 2;
23-
})
24-
.throttle(500, Rx.Scheduler.requestAnimationFrameScheduler)
29+
var keyup = Rx.DOM.keyup(input)
30+
.map(function (ev) { return ev.target.value; })
31+
.filter(function(text) { return text.length > 2; })
32+
.throttle(500)
2533
.distinctUntilChanged();
2634

2735
var searcher = keyup.flatMapLatest(searchWikipedia).map(function(d) { return d[1]; });
2836

2937
searcher.subscribe(
3038
function (results) {
3139
clearChildren(ul);
32-
33-
for (var i = 0, len = results.length; i < len; i++) {
34-
var li = document.createElement('li');
35-
li.innerHTML = results[i];
36-
ul.appendChild(li);
37-
}
40+
createChildren(results, ul);
3841
},
3942
function (error) {
4043
clearChildren(ul);
41-
var li = document.createElement('li');
42-
li.innerHTML = 'Error: ' + error.message;
43-
ul.appendChild(li);
44+
createElement('Error: ' + error.message, ul);
4445
}
4546
);
4647
}
4748

48-
window.onload = initialize;
49+
Rx.DOM.ready().subscribe(initialize);
4950
}(window));

0 commit comments

Comments
 (0)