Replace TestParameterInjector with cashapp/burst.

Author: ychescale9

build.gradle.kts

@@ -12,6 +12,7 @@ plugins {
     alias(libs.plugins.binaryCompatibilityValidator)
     alias(libs.plugins.detekt)
     alias(libs.plugins.mavenPublish)
+    alias(libs.plugins.burst)
 }
 
 group = property("GROUP") as String
@@ -95,7 +96,6 @@ val fixtureAgpVersion: Provider<String> = providers
 dependencies {
     compileOnly(libs.agp.build.api)
     testImplementation(kotlin("test"))
-    testImplementation(libs.testParameterInjector)
     fixtureClasspath(libs.agp.build.gradle.flatMap { dependency ->
         fixtureAgpVersion.map { version ->
             "${dependency.group}:${dependency.name}:$version"

gradle/libs.versions.toml

@@ -4,19 +4,19 @@ binaryCompabilityValidator = "0.18.0"
 agp = "8.13.0"
 detekt = "2.0.0-alpha.0"
 mavenPublish = "0.34.0"
-testParameterInjector = "1.18"
+burst = "2.9.0"
 toolchainsResolver = "1.0.0"
 
 [libraries]
 plugin-detektKtlintWrapper = { module = "dev.detekt:detekt-rules-ktlint-wrapper", version.ref = "detekt"}
 
 agp-build-gradle = { module = "com.android.tools.build:gradle", version.ref = "agp" }
 agp-build-api = { module = "com.android.tools.build:gradle-api", version.ref = "agp" }
-testParameterInjector = { group = "com.google.testparameterinjector", name = "test-parameter-injector", version.ref = "testParameterInjector" }
 
 [plugins]
 kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
 kotlin-gradle-samWithReceiver = { id = "org.jetbrains.kotlin.plugin.sam.with.receiver", version.ref = "kotlin" }
 binaryCompatibilityValidator = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version.ref = "binaryCompabilityValidator" }
 detekt = { id = "dev.detekt", version.ref = "detekt" }
 mavenPublish = { id = "com.vanniktech.maven.publish", version.ref = "mavenPublish" }
+burst = { id = "app.cash.burst", version.ref = "burst" }

src/functionalTest/kotlin/io/github/reactivecircus/appversioning/AppVersioningPluginIntegrationTest.kt

@@ -1,10 +1,10 @@
-@file:Suppress("FunctionName")
+@file:Suppress("FunctionName", "JUnitMalformedDeclaration")
 
 package io.github.reactivecircus.appversioning
 
-import com.google.testing.junit.testparameterinjector.TestParameter
-import com.google.testing.junit.testparameterinjector.TestParameterInjector
+import app.cash.burst.Burst
 import io.github.reactivecircus.appversioning.fixtures.AppProjectTemplate
+import io.github.reactivecircus.appversioning.fixtures.BuildScriptLanguage
 import io.github.reactivecircus.appversioning.fixtures.LibraryProjectTemplate
 import io.github.reactivecircus.appversioning.fixtures.withFixtureRunner
 import io.github.reactivecircus.appversioning.internal.GitClient
@@ -14,15 +14,14 @@ import org.gradle.testkit.runner.TaskOutcome
 import org.junit.Rule
 import org.junit.Test
 import org.junit.rules.TemporaryFolder
-import org.junit.runner.RunWith
 import java.io.File
 import kotlin.test.assertEquals
 import kotlin.test.assertFalse
 import kotlin.test.assertNull
 import kotlin.test.assertTrue
 
-@RunWith(TestParameterInjector::class)
-class AppVersioningPluginIntegrationTest {
+@Burst
+class AppVersioningPluginIntegrationTest(private val buildScriptLanguage: BuildScriptLanguage) {
     @get:Rule
     val fixtureDir = TemporaryFolder()
 
@@ -81,15 +80,13 @@ class AppVersioningPluginIntegrationTest {
     }
 
     @Test
-    fun `plugin tasks are registered for Android App project with product flavors`(
-        @TestParameter useKts: Boolean
-    ) {
+    fun `plugin tasks are registered for Android App project with product flavors`() {
         GitClient.initialize(fixtureDir.root)
 
         val flavors = listOf("mock", "prod")
         withFixtureRunner(
             fixtureDir = fixtureDir,
-            subprojects = listOf(AppProjectTemplate(useKts = useKts, flavors = flavors))
+            subprojects = listOf(AppProjectTemplate(buildScriptLanguage = buildScriptLanguage, flavors = flavors))
         ).runAndCheckResult(
             "tasks",
             "--group=versioning"
@@ -241,17 +238,15 @@ class AppVersioningPluginIntegrationTest {
     }
 
     @Test
-    fun `plugin generates versionCode and versionName for the assembled APK when assemble task is run`(
-        @TestParameter useKts: Boolean
-    ) {
+    fun `plugin generates versionCode and versionName for the assembled APK when assemble task is run`() {
         GitClient.initialize(fixtureDir.root).apply {
             val commitId = commit(message = "1st commit.")
             tag(name = "1.2.3", message = "1st tag", commitId = commitId)
         }
 
         withFixtureRunner(
             fixtureDir = fixtureDir,
-            subprojects = listOf(AppProjectTemplate(useKts = useKts))
+            subprojects = listOf(AppProjectTemplate(buildScriptLanguage = buildScriptLanguage))
         ).runAndCheckResult(
             "assembleRelease"
         ) {
@@ -276,17 +271,15 @@ class AppVersioningPluginIntegrationTest {
     }
 
     @Test
-    fun `plugin generates versionCode and versionName for the assembled APKs when splits-APKs is enabled`(
-        @TestParameter useKts: Boolean
-    ) {
+    fun `plugin generates versionCode and versionName for the assembled APKs when splits-APKs is enabled`() {
         GitClient.initialize(fixtureDir.root).apply {
             val commitId = commit(message = "1st commit.")
             tag(name = "1.2.3", message = "1st tag", commitId = commitId)
         }
 
         withFixtureRunner(
             fixtureDir = fixtureDir,
-            subprojects = listOf(AppProjectTemplate(useKts = useKts, splitsApks = true))
+            subprojects = listOf(AppProjectTemplate(buildScriptLanguage = buildScriptLanguage, splitsApks = true))
         ).runAndCheckResult(
             "assembleRelease"
         ) {
@@ -311,17 +304,21 @@ class AppVersioningPluginIntegrationTest {
     }
 
     @Test
-    fun `plugin generates versionCode and versionName for the assembled APKs when splits-APKs is enabled and universal mode is on`(
-        @TestParameter useKts: Boolean
-    ) {
+    fun `plugin generates versionCode and versionName for the assembled APKs when splits-APKs is enabled and universal mode is on`() {
         GitClient.initialize(fixtureDir.root).apply {
             val commitId = commit(message = "1st commit.")
             tag(name = "1.2.3", message = "1st tag", commitId = commitId)
         }
 
         withFixtureRunner(
             fixtureDir = fixtureDir,
-            subprojects = listOf(AppProjectTemplate(useKts = useKts, splitsApks = true, universalApk = true))
+            subprojects = listOf(
+                AppProjectTemplate(
+                    buildScriptLanguage = buildScriptLanguage,
+                    splitsApks = true,
+                    universalApk = true,
+                )
+            )
         ).runAndCheckResult(
             "assembleRelease"
         ) {
@@ -359,7 +356,12 @@ class AppVersioningPluginIntegrationTest {
         """.trimIndent()
         withFixtureRunner(
             fixtureDir = fixtureDir,
-            subprojects = listOf(AppProjectTemplate(pluginExtension = extension))
+            subprojects = listOf(
+                AppProjectTemplate(
+                    buildScriptLanguage = buildScriptLanguage,
+                    pluginExtension = extension,
+                )
+            )
         ).runAndCheckResult(
             "assembleRelease"
         ) {

src/functionalTest/kotlin/io/github/reactivecircus/appversioning/fixtures/FixtureRunner.kt

@@ -83,7 +83,11 @@ private fun TemporaryFolder.buildFixture(gradleRoot: File, subprojects: List<And
     // subprojects
     subprojects.forEach { subproject ->
         // build.gradle or build.gradle.kts
-        val buildFileName = if (subproject.useKts) "build.gradle.kts" else "build.gradle"
+        val buildFileName = if (subproject.buildScriptLanguage == BuildScriptLanguage.Kts) {
+            "build.gradle.kts"
+        } else {
+            "build.gradle"
+        }
         gradleRoot.resolve("${subproject.projectName}/$buildFileName").also { it.parentFile.mkdirs() }
             .writeText(subproject.buildFileContent)
 

src/functionalTest/kotlin/io/github/reactivecircus/appversioning/fixtures/ProjectTemplates.kt

@@ -43,13 +43,22 @@ fun gradlePropertiesFileContent(enableConfigurationCache: Boolean): String {
     """.trimIndent()
 }
 
+enum class BuildScriptLanguage {
+    Kts,
+    Groovy,
+}
+
 sealed class AndroidProjectTemplate {
     abstract val projectName: String
     abstract val pluginExtension: String?
-    abstract val useKts: Boolean
+    abstract val buildScriptLanguage: BuildScriptLanguage
     abstract val flavors: List<String>
 
-    val buildFileContent: String get() = if (useKts) ktsBuildFileContent else groovyBuildFileContent
+    val buildFileContent: String get() = if (buildScriptLanguage == BuildScriptLanguage.Kts) {
+        ktsBuildFileContent
+    } else {
+        groovyBuildFileContent
+    }
 
     private val isAppProject = this is AppProjectTemplate
 
@@ -181,7 +190,7 @@ sealed class AndroidProjectTemplate {
 class AppProjectTemplate(
     override val projectName: String = "app",
     override val pluginExtension: String? = null,
-    override val useKts: Boolean = true,
+    override val buildScriptLanguage: BuildScriptLanguage = BuildScriptLanguage.Kts,
     override val flavors: List<String> = emptyList(),
     val splitsApks: Boolean = false,
     val universalApk: Boolean = false,
@@ -190,6 +199,6 @@ class AppProjectTemplate(
 class LibraryProjectTemplate(
     override val projectName: String = "library",
     override val pluginExtension: String? = null,
-    override val useKts: Boolean = true,
+    override val buildScriptLanguage: BuildScriptLanguage = BuildScriptLanguage.Kts,
     override val flavors: List<String> = emptyList()
 ) : AndroidProjectTemplate()

src/functionalTest/kotlin/io/github/reactivecircus/appversioning/tasks/GenerateAppVersionInfoTest.kt

@@ -3,6 +3,7 @@
 package io.github.reactivecircus.appversioning.tasks
 
 import io.github.reactivecircus.appversioning.fixtures.AppProjectTemplate
+import io.github.reactivecircus.appversioning.fixtures.BuildScriptLanguage
 import io.github.reactivecircus.appversioning.fixtures.withFixtureRunner
 import io.github.reactivecircus.appversioning.internal.GitClient
 import org.gradle.testkit.runner.TaskOutcome
@@ -713,7 +714,12 @@ class GenerateAppVersionInfoTest {
 
         val runner = withFixtureRunner(
             fixtureDir = fixtureDir,
-            subprojects = listOf(AppProjectTemplate(pluginExtension = extensions, useKts = false))
+            subprojects = listOf(
+                AppProjectTemplate(
+                    pluginExtension = extensions,
+                    buildScriptLanguage = BuildScriptLanguage.Groovy,
+                )
+            )
         )
 
         runner.runAndCheckResult(

src/main/kotlin/io/github/reactivecircus/appversioning/tasks/GenerateAppVersionInfo.kt

@@ -1,5 +1,3 @@
-@file:Suppress("DuplicatedCode")
-
 package io.github.reactivecircus.appversioning.tasks
 
 import groovy.lang.Closure