Skip to content

Commit 8d3a4da

Browse files
committed
Remove kotlin-dsl.
1 parent af86964 commit 8d3a4da

File tree

5 files changed

+14
-8
lines changed

5 files changed

+14
-8
lines changed

build.gradle.kts

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@ import org.jetbrains.kotlin.gradle.dsl.JvmTarget
66
import org.jetbrains.kotlin.gradle.tasks.KotlinCompile
77

88
plugins {
9-
`kotlin-dsl`
9+
`java-gradle-plugin`
10+
alias(libs.plugins.kotlin.gradle.samWithReceiver)
1011
alias(libs.plugins.kotlin.jvm)
1112
alias(libs.plugins.binaryCompatibilityValidator)
1213
alias(libs.plugins.detekt)
@@ -21,6 +22,10 @@ mavenPublishing {
2122
signAllPublications()
2223
}
2324

25+
samWithReceiver {
26+
annotation(HasImplicitReceiver::class.qualifiedName!!)
27+
}
28+
2429
gradlePlugin {
2530
website.set(property("POM_URL") as String)
2631
vcsUrl.set(property("POM_SCM_URL") as String)

gradle/libs.versions.toml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ testParameterInjector = { group = "com.google.testparameterinjector", name = "te
1616

1717
[plugins]
1818
kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" }
19+
kotlin-gradle-samWithReceiver = { id = "org.jetbrains.kotlin.plugin.sam.with.receiver", version.ref = "kotlin" }
1920
binaryCompatibilityValidator = { id = "org.jetbrains.kotlinx.binary-compatibility-validator", version.ref = "binaryCompabilityValidator" }
2021
detekt = { id = "io.gitlab.arturbosch.detekt", version.ref = "detekt" }
2122
mavenPublish = { id = "com.vanniktech.maven.publish", version.ref = "mavenPublish" }

src/main/kotlin/io/github/reactivecircus/appversioning/AppVersioningExtension.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,13 @@ package io.github.reactivecircus.appversioning
22

33
import groovy.lang.Closure
44
import org.gradle.api.model.ObjectFactory
5+
import org.gradle.api.provider.Property
56
import org.gradle.api.provider.ProviderFactory
6-
import org.gradle.kotlin.dsl.property
77

88
/**
99
* Extension for [AppVersioningPlugin].
1010
*/
11-
@Suppress("UnstableApiUsage", "unused")
11+
@Suppress("unused")
1212
open class AppVersioningExtension internal constructor(objects: ObjectFactory) {
1313

1414
/**
@@ -125,5 +125,7 @@ open class AppVersioningExtension internal constructor(objects: ObjectFactory) {
125125
}
126126
}
127127

128+
private inline fun <reified T : Any> ObjectFactory.property(): Property<T> = property(T::class.java)
129+
128130
internal typealias VersionCodeCustomizer = (GitTag, ProviderFactory, VariantInfo) -> Int
129131
internal typealias VersionNameCustomizer = (GitTag, ProviderFactory, VariantInfo) -> String

src/main/kotlin/io/github/reactivecircus/appversioning/AppVersioningPlugin.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,6 @@ import io.github.reactivecircus.appversioning.tasks.PrintAppVersionInfo
88
import org.gradle.api.Plugin
99
import org.gradle.api.Project
1010
import org.gradle.api.tasks.TaskProvider
11-
import org.gradle.kotlin.dsl.getByType
12-
import org.gradle.kotlin.dsl.withType
1311
import org.gradle.language.nativeplatform.internal.BuildType
1412
import java.io.File
1513
import java.util.Locale
@@ -24,9 +22,9 @@ class AppVersioningPlugin : Plugin<Project> {
2422
val androidAppPluginApplied = AtomicBoolean(false)
2523
val pluginDisabled = AtomicBoolean(false)
2624
val appVersioningExtension = project.extensions.create("appVersioning", AppVersioningExtension::class.java)
27-
project.plugins.withType<AppPlugin> {
25+
project.plugins.withType(AppPlugin::class.java) {
2826
androidAppPluginApplied.set(true)
29-
val extension = project.extensions.getByType<ApplicationAndroidComponentsExtension>()
27+
val extension = project.extensions.getByType(ApplicationAndroidComponentsExtension::class.java)
3028
extension.onVariants(selector = extension.selector().all()) { variant ->
3129
if (pluginDisabled.get()) return@onVariants
3230
if (!appVersioningExtension.enabled.get()) {

src/main/kotlin/io/github/reactivecircus/appversioning/tasks/GenerateAppVersionInfo.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
@file:Suppress("UnstableApiUsage", "DuplicatedCode")
1+
@file:Suppress("DuplicatedCode")
22

33
package io.github.reactivecircus.appversioning.tasks
44

0 commit comments

Comments
 (0)