Removing Result in favor of Swift.Result (#702)

* Removed Result

* Removing Result from project

* Added NoError and ResultProtocol for Swift.Result

* Using Swift.Error in lieu of AnyError

* Replaced NoError with Never

* Test fixes

* Specify the correct Error type in Never overloads

* Fix tests

* Update SwiftPM

* Update CI

* Remove the last vestiges of Result.framework

* Rename assumeNevers back to assumeNoErrors

Author: NachoSoto

.gitmodules

@@ -7,6 +7,3 @@
 [submodule "Carthage/Checkouts/xcconfigs"]
 	path = Carthage/Checkouts/xcconfigs
 	url = https://github.com/jspahrsummers/xcconfigs.git
-[submodule "Carthage/Checkouts/Result"]
-	path = Carthage/Checkouts/Result
-	url = https://github.com/antitypical/Result.git

.swift-version

@@ -1 +1 @@
-4.2.1
+5.0

.travis.yml

@@ -1,6 +1,6 @@
 os: osx
 language: objective-c
-osx_image: xcode10.1
+osx_image: xcode10.2
 before_install: true
 install: true
 branches:
@@ -68,25 +68,10 @@ aliases:
 matrix:
   include:
     - <<: *xcode
-    - <<: *xcode
-      osx_image: xcode10.2
-    # - <<: *xcode
-    #   osx_image: xcode10.2
-    #   env: XCODE_ARGS="SWIFT_VERSION=5.0"
     - <<: *cocoapods
       install: gem update cocoapods
     - <<: *swiftpm_darwin
-    - <<: *swiftpm_darwin
-      osx_image: xcode10.2
-    - <<: *swiftpm_linux
     - <<: *swiftpm_linux
-      env:
-        - JOB=SwiftPM
-        - SWIFT_VERSION=4.2.3
-    - <<: *swiftpm_linux
-      env:
-        - JOB=SwiftPM
-        - SWIFT_VERSION=5.0-DEVELOPMENT-SNAPSHOT-2019-02-28-a
     - stage: carthage
       script: carthage build --cache-builds --no-skip-current
     - stage: deploy

Cartfile

@@ -1 +0,0 @@
-github "antitypical/Result" ~> 4.1

Cartfile.resolved

@@ -1,4 +1,3 @@
 github "Quick/Nimble" "v8.0.0"
 github "Quick/Quick" "v2.0.0"
-github "antitypical/Result" "4.1.0"
 github "jspahrsummers/xcconfigs" "0.12"

Carthage/Checkouts/Result

@@ -1,4 +1,4 @@
-// swift-tools-version:4.0
+// swift-tools-version:5.0
 import PackageDescription
 
 let package = Package(
@@ -7,13 +7,12 @@ let package = Package(
         .library(name: "ReactiveSwift", targets: ["ReactiveSwift"]),
     ],
     dependencies: [
-        .package(url: "https://github.com/antitypical/Result.git", from: "4.1.0"),
         .package(url: "https://github.com/Quick/Quick.git", from: "2.0.0"),
         .package(url: "https://github.com/Quick/Nimble.git", from: "8.0.0"),
     ],
     targets: [
-        .target(name: "ReactiveSwift", dependencies: ["Result"], path: "Sources"),
+        .target(name: "ReactiveSwift", dependencies: [], path: "Sources"),
         .testTarget(name: "ReactiveSwiftTests", dependencies: ["ReactiveSwift", "Quick", "Nimble"]),
     ],
-    swiftLanguageVersions: [4]
+    swiftLanguageVersions: [.v5]
 )

Package.resolved

@@ -75,7 +75,7 @@ ReactiveSwift to your `Cartfile`:
 github "ReactiveCocoa/ReactiveSwift" ~> 5.0
 ```
 
-If you use Carthage to build your dependencies, make sure you have added `ReactiveSwift.framework`, and `Result.framework` to the "_Linked Frameworks and Libraries_" section of your target, and have included them in your Carthage framework copying build phase.
+If you use Carthage to build your dependencies, make sure you have added `ReactiveSwift.framework` to the "_Linked Frameworks and Libraries_" section of your target, and have included them in your Carthage framework copying build phase.
 
 #### CocoaPods
 
@@ -100,12 +100,10 @@ of your package in `Package.swift`:
  1. Add the ReactiveSwift repository as a [submodule][] of your
     application’s repository.
  1. Run `git submodule update --init --recursive` from within the ReactiveCocoa folder.
- 1. Drag and drop `ReactiveSwift.xcodeproj` and
-    `Carthage/Checkouts/Result/Result.xcodeproj` into your application’s Xcode
+ 1. Drag and drop `ReactiveSwift.xcodeproj` into your application’s Xcode
     project or workspace.
  1. On the “General” tab of your application target’s settings, add
-    `ReactiveSwift.framework`, and `Result.framework`
-    to the “Embedded Binaries” section.
+    `ReactiveSwift.framework` to the “Embedded Binaries” section.
  1. If your application target does not contain Swift code at all, you should also
     set the `EMBEDDED_CONTENT_CONTAINS_SWIFT` build setting to “Yes”.