Skip to content

Commit 5d8101a

Browse files
authored
Update to Nimble 9.0 and Quick 3.0 (#811)
1 parent d7f60d9 commit 5d8101a

File tree

10 files changed

+37
-16
lines changed

10 files changed

+37
-16
lines changed

Cartfile.private

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
github "jspahrsummers/xcconfigs" == 0.12
2-
github "Quick/Quick" ~> 2.2.1
3-
github "Quick/Nimble" ~> 8.0.9
2+
github "Quick/Quick" ~> 3.0.0
3+
github "Quick/Nimble" ~> 9.0.0

Cartfile.resolved

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
1-
github "Quick/Nimble" "v8.0.9"
2-
github "Quick/Quick" "v2.2.1"
1+
github "Quick/Nimble" "v9.0.0"
2+
github "Quick/Quick" "v3.0.0"
33
github "jspahrsummers/xcconfigs" "0.12"

Carthage/Checkouts/Nimble

Submodule Nimble updated 131 files

Package.resolved

Lines changed: 20 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Package.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ let package = Package(
1111
],
1212
dependencies: [
1313
.package(url: "https://github.com/Quick/Quick.git", from: "3.0.0"),
14-
.package(url: "https://github.com/Quick/Nimble.git", from: "8.0.9"),
14+
.package(url: "https://github.com/Quick/Nimble.git", from: "9.0.0"),
1515
],
1616
targets: [
1717
.target(name: "ReactiveSwift", dependencies: [], path: "Sources"),

Tests/ReactiveSwiftTests/SchedulerSpec.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ class SchedulerSpec: QuickSpec {
229229
expect(count) == 0
230230

231231
scheduler.queue.resume()
232-
expect(count).toEventually(equal(timesToIncrement), pollInterval: 0.1)
232+
expect(count).toEventually(equal(timesToIncrement), pollInterval: .milliseconds(100))
233233
}
234234

235235
it("should cancel repeatedly run actions on disposal") {

Tests/ReactiveSwiftTests/SignalProducerNimbleMatchers.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,15 +44,15 @@ public func sendValues<T: Equatable, E: Equatable>(_ values: [T], sendError mayb
4444
if sentValues != values {
4545
let message = ExpectationMessage.expectedCustomValueTo(
4646
"send values <\(values)>",
47-
"<\(sentValues)>"
47+
actual: "<\(sentValues)>"
4848
)
4949
return PredicateResult(status: .doesNotMatch, message: message)
5050
}
5151

5252
if sentError != maybeSendError {
5353
let message = ExpectationMessage.expectedCustomValueTo(
5454
"send error <\(String(describing: maybeSendError))>",
55-
"<\(String(describing: sentError))>"
55+
actual: "<\(String(describing: sentError))>"
5656
)
5757
return PredicateResult(status: .doesNotMatch, message: message)
5858
}

Tests/ReactiveSwiftTests/SignalProducerSpec.swift

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2918,7 +2918,7 @@ class SignalProducerSpec: QuickSpec {
29182918
expect(result).to(beNil())
29192919

29202920
observer.send(value: 1)
2921-
expect(result).toEventually(equal(1), timeout: 5.0)
2921+
expect(result).toEventually(equal(1), timeout: .seconds(5))
29222922
}
29232923

29242924
it("should return a nil result if no values are sent before completion") {
@@ -3746,8 +3746,11 @@ class SignalProducerSpec: QuickSpec {
37463746
// MARK: - Helpers
37473747

37483748
private func == <T>(left: Expectation<T.Type>, right: Any.Type) {
3749-
left.to(Predicate.fromDeprecatedClosure { expression, _ in
3750-
return try expression.evaluate()! == right
3749+
left.to(Predicate { expression in
3750+
PredicateResult(
3751+
bool: try expression.evaluate()! == right,
3752+
message: ExpectationMessage.expectedActualValueTo("equal to")
3753+
)
37513754
}.requireNonNil)
37523755
}
37533756

Tests/ReactiveSwiftTests/SignalSpec.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,7 @@ class SignalSpec: QuickSpec {
357357
group.wait()
358358

359359
expect(executionCounter.value) == iterations * 2
360-
expect(counter.value).toEventually(equal(iterations), timeout: 5)
360+
expect(counter.value).toEventually(equal(iterations), timeout: .seconds(5))
361361
}
362362
}
363363

0 commit comments

Comments
 (0)