Rename withLatest(_:) to withLatest(from:)

Author: inamiy

Sources/Signal.swift

@@ -1036,7 +1036,7 @@ extension SignalProtocol {
 	///            sampled (possibly multiple times) by `self`, then terminate
 	///            once `self` has terminated. **`samplee`'s terminated events
 	///            are ignored**.
-	public func withLatest<U>(_ samplee: Signal<U, NoError>) -> Signal<(Value, U), Error> {
+	public func withLatest<U>(from samplee: Signal<U, NoError>) -> Signal<(Value, U), Error> {
 		return Signal { observer in
 			let state = Atomic<U?>(nil)
 			let disposable = CompositeDisposable()
@@ -1079,12 +1079,12 @@ extension SignalProtocol {
 	///            sampled (possibly multiple times) by `self`, then terminate
 	///            once `self` has terminated. **`samplee`'s terminated events
 	///            are ignored**.
-	public func withLatest<U>(_ samplee: SignalProducer<U, NoError>) -> Signal<(Value, U), Error> {
+	public func withLatest<U>(from samplee: SignalProducer<U, NoError>) -> Signal<(Value, U), Error> {
 		return Signal { observer in
 			let d = CompositeDisposable()
 			samplee.startWithSignal { signal, disposable in
 				d += disposable
-				d += self.withLatest(signal).observe(observer)
+				d += self.withLatest(from: signal).observe(observer)
 			}
 			return d
 		}

Sources/SignalProducer.swift

@@ -827,7 +827,7 @@ extension SignalProducerProtocol {
 	///            sampled (possibly multiple times) by `self`, then terminate
 	///            once `self` has terminated. **`samplee`'s terminated events
 	///            are ignored**.
-	public func withLatest<U>(_ samplee: SignalProducer<U, NoError>) -> SignalProducer<(Value, U), Error> {
+	public func withLatest<U>(from samplee: SignalProducer<U, NoError>) -> SignalProducer<(Value, U), Error> {
 		return liftRight(Signal.withLatest)(samplee)
 	}
 
@@ -846,7 +846,7 @@ extension SignalProducerProtocol {
 	///            sampled (possibly multiple times) by `self`, then terminate
 	///            once `self` has terminated. **`samplee`'s terminated events
 	///            are ignored**.
-	public func withLatest<U>(_ samplee: Signal<U, NoError>) -> SignalProducer<(Value, U), Error> {
+	public func withLatest<U>(from samplee: Signal<U, NoError>) -> SignalProducer<(Value, U), Error> {
 		return lift(Signal.withLatest)(samplee)
 	}
 

Tests/ReactiveSwiftTests/SignalProducerLiftingSpec.swift

@@ -1114,15 +1114,15 @@ class SignalProducerLiftingSpec: QuickSpec {
 			}
 		}
 
-		describe("withLatest(signal)") {
+		describe("withLatest(from: signal)") {
 			var withLatestProducer: SignalProducer<(Int, String), NoError>!
 			var observer: Signal<Int, NoError>.Observer!
 			var sampleeObserver: Signal<String, NoError>.Observer!
 
 			beforeEach {
 				let (producer, incomingObserver) = SignalProducer<Int, NoError>.pipe()
 				let (samplee, incomingSampleeObserver) = Signal<String, NoError>.pipe()
-				withLatestProducer = producer.withLatest(samplee)
+				withLatestProducer = producer.withLatest(from: samplee)
 				observer = incomingObserver
 				sampleeObserver = incomingSampleeObserver
 			}
@@ -1180,15 +1180,15 @@ class SignalProducerLiftingSpec: QuickSpec {
 			}
 		}
 
-		describe("withLatest(producer)") {
+		describe("withLatest(from: producer)") {
 			var withLatestProducer: SignalProducer<(Int, String), NoError>!
 			var observer: Signal<Int, NoError>.Observer!
 			var sampleeObserver: Signal<String, NoError>.Observer!
 
 			beforeEach {
 				let (producer, incomingObserver) = SignalProducer<Int, NoError>.pipe()
 				let (samplee, incomingSampleeObserver) = SignalProducer<String, NoError>.pipe()
-				withLatestProducer = producer.withLatest(samplee)
+				withLatestProducer = producer.withLatest(from: samplee)
 				observer = incomingObserver
 				sampleeObserver = incomingSampleeObserver
 			}

Tests/ReactiveSwiftTests/SignalSpec.swift

@@ -1628,15 +1628,15 @@ class SignalSpec: QuickSpec {
 			}
 		}
 
-		describe("withLatest(signal)") {
+		describe("withLatest(from: signal)") {
 			var withLatestSignal: Signal<(Int, String), NoError>!
 			var observer: Signal<Int, NoError>.Observer!
 			var sampleeObserver: Signal<String, NoError>.Observer!
 
 			beforeEach {
 				let (signal, incomingObserver) = Signal<Int, NoError>.pipe()
 				let (samplee, incomingSampleeObserver) = Signal<String, NoError>.pipe()
-				withLatestSignal = signal.withLatest(samplee)
+				withLatestSignal = signal.withLatest(from: samplee)
 				observer = incomingObserver
 				sampleeObserver = incomingSampleeObserver
 			}
@@ -1697,15 +1697,15 @@ class SignalSpec: QuickSpec {
 			}
 		}
 
-		describe("withLatest(producer)") {
+		describe("withLatest(from: producer)") {
 			var withLatestSignal: Signal<(Int, String), NoError>!
 			var observer: Signal<Int, NoError>.Observer!
 			var sampleeObserver: Signal<String, NoError>.Observer!
 
 			beforeEach {
 				let (signal, incomingObserver) = Signal<Int, NoError>.pipe()
 				let (samplee, incomingSampleeObserver) = SignalProducer<String, NoError>.pipe()
-				withLatestSignal = signal.withLatest(samplee)
+				withLatestSignal = signal.withLatest(from: samplee)
 				observer = incomingObserver
 				sampleeObserver = incomingSampleeObserver
 			}