Remove NoError variant of SignalProducer.init(_ action: @escaping () -> Value)

Author: ikesyo

Sources/SignalProducer.swift

@@ -250,23 +250,6 @@ extension SignalProducer where Error == NoError {
 		}
 	}
 
-	/// Creates a producer for a `Signal` that immediately sends one value, then
-	/// completes.
-	///
-	/// This initializer differs from `init(value:)` in that its sole `value`
-	/// event is constructed lazily by invoking the supplied `action` when
-	/// the `SignalProducer` is started.
-	///
-	/// - parameters:
-	///   - action: A action that yields a value to be sent by the `Signal` as
-	///             a `value` event.
-	public init(_ action: @escaping () -> Value) {
-		self.init { observer, _ in
-			observer.send(value: action())
-			observer.sendCompleted()
-		}
-	}
-
 	/// Creates a producer for a Signal that will immediately send the values
 	/// from the given sequence, then complete.
 	///

Tests/ReactiveSwiftTests/SignalProducerSpec.swift

@@ -229,11 +229,12 @@ class SignalProducerSpec: QuickSpec {
 				let resultAction2: () -> Result<String, AnyError> = { .success("") }
 				let throwableResultAction: () throws -> Result<String, NoError> = { .success("") }
 
-				expect(type(of: SignalProducer(action))) == SignalProducer<String, NoError>.self
-				expect(type(of: SignalProducer<String, AnyError>(action))) == SignalProducer<String, AnyError>.self
+				expect(type(of: SignalProducer(action))) == SignalProducer<String, AnyError>.self
+				expect(type(of: SignalProducer<String, NoError>(action))) == SignalProducer<String, NoError>.self
+				expect(type(of: SignalProducer<String, TestError>(action))) == SignalProducer<String, TestError>.self
 
-				expect(type(of: SignalProducer<String, NoError>(resultAction1))) == SignalProducer<String, NoError>.self
-				expect(type(of: SignalProducer<String, AnyError>(resultAction2))) == SignalProducer<String, AnyError>.self
+				expect(type(of: SignalProducer(resultAction1))) == SignalProducer<String, NoError>.self
+				expect(type(of: SignalProducer(resultAction2))) == SignalProducer<String, AnyError>.self
 
 				expect(type(of: SignalProducer(throwableAction))) == SignalProducer<String, AnyError>.self
 				expect(type(of: SignalProducer(throwableResultAction))) == SignalProducer<Result<String, NoError>, AnyError>.self
@@ -366,8 +367,8 @@ class SignalProducerSpec: QuickSpec {
 					return .success("OperationValue")
 				}
 
-				SignalProducer<String, NSError>(operation).start()
-				SignalProducer<String, NSError>(operation).start()
+				SignalProducer(operation).start()
+				SignalProducer(operation).start()
 
 				expect(operationRunTimes) == 2
 			}
@@ -378,7 +379,7 @@ class SignalProducerSpec: QuickSpec {
 					return .success(operationReturnValue)
 				}
 
-				let signalProducer = SignalProducer<String, NSError>(operation)
+				let signalProducer = SignalProducer(operation)
 
 				expect(signalProducer).to(sendValue(operationReturnValue, sendError: nil, complete: true))
 			}
@@ -389,7 +390,7 @@ class SignalProducerSpec: QuickSpec {
 					return .failure(operationError)
 				}
 
-				let signalProducer = SignalProducer<String, NSError>(operation)
+				let signalProducer = SignalProducer(operation)
 
 				expect(signalProducer).to(sendValue(nil, sendError: operationError, complete: false))
 			}