Skip to content

Commit df18eb3

Browse files
author
Nikolas Mayr
authored
Increased performance of joining signals by a factor of around 5 (#773)
* increased performance of joining signals by a factor of around 5 - this becomes relevant, when joining a 1000 signals and more * updated changelog
1 parent 22ab0df commit df18eb3

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
# master
22
*Please add new entries at the top.*
33

4+
1. Improved performance of joining signals by a factor of around 5. This enables joining of 1000 and more signals in a reasonable amount of time.
45
1. Fixed `SignalProducer.debounce` operator that, when started more than once, would not deliver values on producers started after the first time. (#772, kudos to @gpambrozio)
56
1. `FlattenStrategy.throttle` is introduced. (#713, kudos to @inamiy)
67
1. Updated `README.md` to reflect Swift 5.1 compatibility and point snippets to 6.1.0 (#763, kudos to @Marcocanc)

Sources/Signal.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1680,7 +1680,7 @@ extension Signal {
16801680
return true
16811681
}
16821682

1683-
_haveAllSentInitial = values.reduce(true) { $0 && !($1 is Placeholder) }
1683+
_haveAllSentInitial = values.allSatisfy{ !($0 is Placeholder) }
16841684
return _haveAllSentInitial
16851685
}
16861686
}

0 commit comments

Comments
 (0)